-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom JS files #2786
Comments
Hi, thanks for the ticket. I recall someone else (maybe CSC) wanting Matomo support directly so that could be an option. I'm a little weary to add this directly. It could introduce a big vulnerability. On the other hand, there's clearly something you need that we don't support directly so ... it does add support for a lot of things indirectly. |
Created an implementation proposal based on the custom CSS feature: |
Yea thinking about this again, it really comes down to having a strong CSP and if we can secure the assets we serve, which that PR seems to do. |
I think that might have been us at CSC wanting Matomo support indeed. We do some slight customization of what data is reported though, so not sure if a generic solution would be suitable for us. We for example sanitize the files app URLs and add tracking for Shell app launches.
That is great, thank you. |
The new custom CSS feature (#2150) introduced in OOD 3.0 is quite nice. It would be nice to have a similar feature available for including custom JS files.
As an example, the JS we would like to include consists of Matomo tracking code and some code used in all interactive app forms, which we would like to avoid copying across all of the
form.js
files and include globally instead.Currently, we include these JS files by overriding
views/layouts/application.html.erb
, but an officially supported method for accomplishing this would be great.┆Issue is synchronized with this Asana task by Unito
The text was updated successfully, but these errors were encountered: