Clamp bugfix #2365
Merged
Clamp bugfix #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
commented
Nov 9, 2022
Comment on lines
-426
to
+427
| } else if(previous && previous['max'] && currentValue == previous['max']) { | ||
| return next['max']; | ||
| } else if(previous && previous['min'] && currentValue == previous['min']) { | ||
| } else if(currentValue === previous['min']) { |
There was a problem hiding this comment.
previous['max'] can be 0 which evaluates to fasley - so just stop checking for it's existance because javascript deals well with comparing undefined or null against actual objects.
This also makes sure we check the minimum before the maximum so things get clamped to the minimums.
johrstrom
commented
Nov 9, 2022
Comment on lines
+92
to
+97
| data-hide-cuda-version: "true", | ||
| data-hide-advanced-options: "true", | ||
| data-min-bc-num-slots: "100", | ||
| data-max-bc-num-slots: "200", | ||
| data-min-bc-num-hours: "444", | ||
| data-max-bc-num-hours: "555", |
There was a problem hiding this comment.
These modifications on old tests are just to be sure that when folks use strings instead of integers or booleans everything still works as expected.
johrstrom
added a commit
that referenced
this pull request
Dec 7, 2022
Fix clamping to and from 0 to behave correctly.
johrstrom
added a commit
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2362 which ended up being a few bugs. I'll leave comments for rationale for changes in the files.
┆Issue is synchronized with this Asana task by Unito
┆Link To Task: https://app.asana.com/0/1135148780858012/1203338277276811