Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamping to or from 0 seems broken #2362

Closed
johrstrom opened this issue Nov 7, 2022 · 0 comments · Fixed by #2365
Closed

clamping to or from 0 seems broken #2362

johrstrom opened this issue Nov 7, 2022 · 0 comments · Fixed by #2365
Labels
bug Existing functionality not working as expected
Milestone

Comments

@johrstrom
Copy link
Contributor

johrstrom commented Nov 7, 2022

We have this for the ascend cluster and given the steps below

form:
  - gpus
  - node_type
attributes:
  gpus:
    widget: number_field
    value: 0
    min: 0
    max: 4
  node_type:
    widget: select
    label: "Node type"
    help: |
      Need docs
    options:
      - [ 
          "cpu", "any",
          data-min-num-cores: 1,
          data-min-gpus: 0,
          data-max-gpus: 0,
          data-max-num-cores: 84,
          data-hide-gpus: true,
        ]
      - [ 
          "gpu", "gpu-any",
          data-min-gpus: 1,
          data-max-gpus: 4,
          data-min-num-cores: 1,
          data-max-num-cores: 88,
        ]

steps to reproduce:

  • set the node_type to gpus
  • set gpus to 0
  • select node type cpu
  • select node type gpu
  • [bug] see that gpus is now set to 4 when it should have been set to 0.

┆Issue is synchronized with this Asana task by Unito
┆Link To Task: https://app.asana.com/0/1202821104799596/1203325968198874

@johrstrom johrstrom added the bug Existing functionality not working as expected label Nov 7, 2022
@osc-bot osc-bot added this to the Backlog milestone Nov 7, 2022
@johrstrom johrstrom mentioned this issue Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants