Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start of a new icon picker. #1794

Merged
merged 3 commits into from
Feb 1, 2022
Merged

start of a new icon picker. #1794

merged 3 commits into from
Feb 1, 2022

Conversation

johrstrom
Copy link
Contributor

@johrstrom johrstrom commented Jan 27, 2022

Start of a new icon picker to fix. This replaces the old icon picker outright. Though it fixes a few bugs, it does remove the search functionality.

Test by saving apps with new icons when you edit them. Not all icons work, as I mention in a comment I hand picked some icons that don't work.

Fixes #1375
Fixes #1514

before

image

Now

image

┆Issue is synchronized with this Asana task by Unito

@johrstrom johrstrom marked this pull request as ready for review January 31, 2022 15:58
Copy link
Contributor

@Oglopf Oglopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Oglopf Oglopf merged commit 0dae265 into master Feb 1, 2022
@Oglopf Oglopf deleted the new-iconpicker branch February 1, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate fontawesome-iconpicker.js to webpack font awesome iconpicker broken?
3 participants