font awesome iconpicker broken?

[johrstrom]

Looking into javascript this weekend I came across the javascript files for icons and specifically https://github.com/OSC/ondemand/blob/1f4388222245b0a5d5f42de73b3b438108d4805b/apps/dashboard/app/assets/javascripts/fontawesome-iconpicker.js

Investigating further I traced it to
OSC/ood-dashboard#381
which solved
OSC/ood-dashboard#380

The feature now appears to be broken. I wonder if it's as simple as we stopped importing it at some point? I'm also wondering if we even want to keep it given the original source is archived (https://github.com/itsjavi/fontawesome-iconpicker).

I guess it's a nice little feature - moving it to a pack, and importing in a single page may not be that hard. But looking at the old dashboard repo - there were also some font awesome upgrade PRs, meaning this library would likely have to upgrade at that time too.

┆Issue is synchronized with this Asana task by Unito

[johrstrom]

relevant to #1550 - font awesome will now be in webpack so we can load it's js too if we need.