Update CHANGELOG.md for 2.5.0 #1649

jforissier · 2017-06-29T13:24:24Z

Signed-off-by: Jerome Forissier jerome.forissier@linaro.org

jenswi-linaro · 2017-06-29T13:53:14Z

CHANGELOG.md

+* Make alignment check configurable ([#1586])
+* drivers: add TZC380 driver ([#1578])
+* plat-imx: PSCI CPU off ([#1577])
+* 64-bit paging on QEMU v8 and HiKey ([#1575], [#1592])


Juno and FVP too

sorenb-xlnx · 2017-06-29T13:53:22Z

Things look good on zynqmp:

47112 subtests of which 0 failed
78 test cases of which 0 failed
0 test case was skipped
TEE test application done!

jenswi-linaro · 2017-06-29T14:26:29Z

Tested-by: Jens Wiklander <jens.wiklander@linaro.org> Juno AArch{32,64}
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> Juno AArch{32,64} pager

etienne-lms · 2017-06-29T14:41:26Z

CHANGELOG.md

+* sprd: TBD
+* stm-b2260: TBD
+* stm-cannes: TBD
+* stm-orly2: TBD


stm-olry2 can be deprecated.
Proposed P-R #1650

glneo · 2017-06-29T20:03:42Z

Tested-by: Andrew F. Davis afd@ti.com

For:

ti-dra7xx
ti-am57xx
ti-am43xx

jenswi-linaro · 2017-06-30T05:41:23Z

Tested-by: Jens Wiklander <jens.wiklander@linaro.org> FVP AArch{32,64}
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> FVP AArch{32,64} pager

igoropaniuk · 2017-06-30T08:03:12Z

$ xtest -l 15
+-----------------------------------------------------
47112 subtests of which 0 failed
78 test cases of which 0 failed
0 test case was skipped
TEE test application done!

Tested-by: Igor Opaniuk <igor.opaniuk@linaro.org> (RPi3)
Known #1353 issue still reproduces

jbech-linaro · 2017-06-30T08:36:49Z

NOTICE:  BL31: v1.2(debug):8b2410c
NOTICE:  BL31: Built : 09:52:53, Jun 30 2017
...
INFO:    TEE-CORE: OP-TEE version: 2.5.0-rc1 #1 fre 30 jun 2017 07:52:46 UTC aarch64
...
[    0.000000] Linux version 4.9.0-61854-g2e26af9 (jbech@guppy) (gcc version 6.2.1 20161016 (Linaro GCC 6.2-2016.11) ) #1 SMP PREEMPT Fri Jun 30 09:53:20 CEST 2017

root@MT8173_EVB:/ xtest -l 15
....
+-----------------------------------------------------
47112 subtests of which 0 failed
78 test cases of which 0 failed
0 test case was skipped
TEE test application done!

All fine, but this still uses its own ARM-TF (very old branch). I plan to update to use Liang's new branch after the 2.5.0 release.

Tested-by: Joakim Bech <joakim.bech@linaro.org> (MTK8173)

jforissier · 2017-06-30T09:47:16Z

For tag 2.5.0-rc1:
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)

Aarch32, Aarch64, with and without pager. All test configurations were run with GP tests enabled.
Debian build is OK too.

etienne-lms · 2017-06-30T11:44:00Z

For tag 2.5.0-rc1:
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260, GP)
~~Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (qemu_virt, GP)~~
~~Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (qemu_armv8, GP)~~
=> (edited) both need to be tested back on basis of the latest available QEMU.

Tested with-and-without pager for the 3 setups.
Tested with-and-without-SDP for qemu_armv8.

etienne-lms · 2017-06-30T11:45:06Z

Oups, almost forgotten this one:
`Tested-by: Etienne Carriere etienne.carriere@linaro.org (cannes2, GP)

b49020 · 2017-06-30T12:51:13Z

Tested-by: Sumit Garg sumit.garg@nxp.com (ls1021atwr-single-core)

root@ls1021atwr:~# ./xtest -l 15
Run test suite with level=15
....
+-----------------------------------------------------
47118 subtests of which 0 failed
78 test cases of which 0 failed
0 test case was skipped
TEE test application done!

lorc · 2017-06-30T16:43:25Z

For tag 2.5.0-rc1:

Tested-by: Volodymyr Babchuk <vlad.babchuk@gmail.com> (RCAR H3)

47112 subtests of which 0 failed
78 test cases of which 0 failed
0 test case was skipped
TEE test application done!

jforissier · 2017-06-30T17:07:26Z

Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (D02)

vchong · 2017-07-01T09:52:04Z

For tag 2.5.0-rc1:

Tested by: Victor Chong <victor.chong@linaro.org> (hikey aosp)

23905 subtests of which 0 failed                                                                                       
79 test cases of which 0 failed                                                                                        
0 test case was skipped  
TEE test application done!                                                                                             
root@hikey:/ #

MrVan · 2017-07-03T05:27:06Z

only test with xtest

Tested-by: Peng Fan <peng.fan@nxp.com> (imx-mx7dsabresd)
Tested-by: Peng Fan <peng.fan@nxp.com> (imx-mx6ulevk)
Tested-by: Peng Fan <peng.fan@nxp.com> (imx-mx6ullevk)

jbech-linaro · 2017-07-03T07:24:34Z

@etienne-lms Tested with-and-without-SDP for qemu_armv8.

Did you have any issues with libfdt on QEMU v8? I'm running Ubuntu 16.04.2 LTS and with that I get libfdt 1.4.0+dfsg-2. I.e., it seems like I need to manually update it to latest libfdt like we are doing in Travis, since otherwise QEMU complains that it needs at least libfdt 1.4.2. I.e., if I'm not the only one seeing this, it looks like our manifest/build combination doesn't work for QEMU v8. @jenswi-linaro you also tested v8 according to the comments above. You didn't face the issue?

It would be interesting to know if you get newer libfdt on new Ubuntu versions. Eventually I can try that in Docker.

jenswi-linaro · 2017-07-03T07:57:24Z

@jbech-linaro no I haven't tested qemu yet. I just did a test compile and I'm also facing libfdt issues when compiling qemu.

etienne-lms · 2017-07-03T08:11:55Z

@jbech-linaro: i run an Ubuntu 14.04 LTS and have the libfdt 1.4.0 installed: qemu is fine.
I checked my setup: indeed, I ran the new optee_* 2.5.0-rc1 above an old qemu reference.
I am fetching the full brand new 2.5.0-rc1 manifest and will tell you.

jbech-linaro · 2017-07-03T08:16:51Z

FYI, with Ubuntu 17.04 you will still get the 1.4.0 version (I just checked using Docker). I wonder why they are using such an old version, it's from 2013 (releases). To me it seems like we should update the Makefile in build.git for QEMU_v8, to "manually" checkout the needed version as required by QEMU itself.

etienne-lms · 2017-07-03T09:01:11Z

libfdt issue: proposed OP-TEE/build#156 from Joakim suggestion. Works nice in my env.

etienne-lms · 2017-07-03T14:11:23Z

I removed my Tested-by: tag for the 2 qemu targets as the test I made were based on a older qemu package. This test must be launch from scratch (from fetch the full setup, building and testing).

igoropaniuk · 2017-07-05T13:25:43Z

CHANGELOG.md

+for improved performance.
+* [#1656] qemu_armv8a: init hangs when secure data path and pager are both
+  enabled.
+


For RPi3 still actual #1353

I prefer not to repeat older known problems. In other words, only mention things that have changed compared to the previous release. Perhaps "Known issues" should be renamed to "New issues"?

etienne-lms · 2017-07-05T15:13:36Z

~~Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (qemu_virt)~~
~~Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (qemu_armv8)~~
(Thanks to OP-TEE/manifest#57 and OP-TEE/manifest#58)

Both tested with pager on and off.
Tested with GP testsuite (when pager off).

edited: remove tag, as these were tested against the wrong manifests.

jforissier · 2017-07-05T15:52:46Z

For 2.5.0-rc2:
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (HiKey)

sorenb-xlnx · 2017-07-05T16:32:04Z

For 2.5.0-rc2:

47112 subtests of which 0 failed
78 test cases of which 0 failed
0 test case was skipped
TEE test application done!

Tested-by: Sören Brinkmann <soren.brinkmann@xilinx.com> (zynqmp)

jforissier · 2017-07-05T16:36:01Z

@etienne-lms the qemu_v8 build fails for me with a "core dump" when building edk2. Similar to https://travis-ci.org/OP-TEE/build/jobs/250245963#L5042 actually. Have you seen this already?

repo init -u https://github.com/OP-TEE/manifest.git -m qemu_v8_stable.xml -b 2.5.0-rc2
repo sync -d
cd build
make toolchains
make

etienne-lms · 2017-07-05T16:47:58Z

Ooh, I fetch the latest master for all manifests I tested, not the 2.5.0-rc2 branch.
I will test again all these from scratch tonight.

Hence, once again, i remove by Tested-by: tag for the qemu :(

jbech-linaro · 2017-07-05T17:42:31Z

I think I've seen similar problems, maybe a bit different, in my case I think was missing "iasl" package on my system.

MrVan · 2017-07-06T00:59:33Z

CHANGELOG.md

+* hikey: TBD
+* imx-mx6dlsabresd: TBD
+* imx-mx6qsabrelite: TBD
+* imx-mx6qsabresd: TBD


imx-mx7dsabresd imx-mx6ulevk are also supported.

etienne-lms · 2017-07-06T05:19:20Z

@jforissier : yes same kind of issue.

I followed your command set over the qemu again.

default: fetch/build/run defcfg OK, with pager OK, kaddr-sanitize: issue in regression_6016.1)
default_stable: fetch/build/run defcfg OK, with pager OK, kaddr-sanitize: issue on regression_6016.1)
qemu_v8: not done
=> I expect edk2 build issue since issue on current master of tianocore/edk2.
qemu_v8_stable: build issue on edk2. Faulty commit is the ref (See proposed patch below)
=> fetch/build/run ok (defcfg, pager)

(edited in bold)

etienne-lms · 2017-07-06T06:40:25Z

To fix qemu_v8_stable for 2.5.0 and fix qem_v8 until edk2 issue is fixed:

--- a/qemu_v8.xml
+++ b/qemu_v8.xml
@@ -35,7 +35,8 @@
        <!-- We're using Linaro SWG for ARM-TF until merged officially -->
        <project remote="linaro-swg" path="arm-trusted-firmware" name="arm-trusted-firmware.git" revision="refs/heads/optee_v2.1.0_paged_armtf_v1.2" />
 
-        <!-- Tianocore, EDK2 -->
+        <!-- Tianocore, EDK2 (issue from e4129b0e5897d76885170bec9da996b266f185f9) -->
+        <project name="edk2.git" path="edk2" remote="tianocore" revision="f7bd152c2a05bd75471305184c25f14f01ccf0b7"/>
         <project remote="tianocore" path="edk2" name="edk2.git" />
 
        <!-- strace -->
--- a/qemu_v8_stable.xml
+++ b/qemu_v8_stable.xml
@@ -16,7 +16,7 @@
   <project name="busybox.git" path="busybox" remote="busybox" revision="dbf5a6da6a4295ce26edd1ce34fde567d19afa02"/>
   <project name="code" path="strace" remote="sfnet" revision="c136e9e449fe733e77e8766a9b26e6dc1134203e"/>
   <project name="dtc.git" path="qemu/dtc" remote="qemu" revision="d990b8013889b816ec054c7e07a77db59c56c400"/>
-  <project name="edk2.git" path="edk2" remote="tianocore" revision="e4129b0e5897d76885170bec9da996b266f185f9"/>
+  <project name="edk2.git" path="edk2" remote="tianocore" revision="f7bd152c2a05bd75471305184c25f14f01ccf0b7"/>  
   <project name="gen_rootfs.git" path="gen_rootfs" remote="linaro-swg" revision="cb8c7736a46d1ff459f159b2115395d504c96b45"/>
   <project name="hello_world.git" path="hello_world" remote="linaro-swg" revision="2c15acb431bcde20beb0277c3acdab6d0b4894ef"/>
   <project name="linux.git" path="linux" remote="linaro-swg" revision="cc2e97bbe2ed6290df25087d8967429071abb214"/>

jforissier · 2017-07-06T06:56:06Z

@etienne-lms thanks for investigating. OP-TEE/manifest#62
qemu_v8_stable.xml will be updated when the next tag is created (2.5.0, hopefully).

jbech-linaro · 2017-07-06T06:56:32Z

To fix qemu_v8_stable for 2.5.0 and fix qem_v8 until edk2 issue is fixed:

Good that you found it, what are the odds that it was introduced almost at the same time as we were about to make the release (the one causing the issue was merged 26 hours ago). Luck is not on our side this time :)

vchong · 2017-07-06T07:20:55Z

For tag 2.5.0-rc2:

Tested by: Victor Chong <victor.chong@linaro.org> (hikey aosp)

23906 subtests of which 0 failed                                                                                       
79 test cases of which 0 failed                                                                                        
0 test case was skipped                                                                                                
TEE test application done!                                                                                             
root@hikey:/ #

jbech-linaro · 2017-07-06T08:10:51Z

For tag 2.5.0-rc2:
With OP-TEE/manifest#62 applied on QEMUv8 (only)
Tested-by: Joakim Bech <joakim.bech@linaro.org> (Juno, QEMUv7, QEMUv8, FVP, MTK8173)

jforissier · 2017-07-06T08:11:11Z

For tag 2.5.0-rc2:
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (D02)

jforissier · 2017-07-06T12:25:30Z

The HiKey Debian build (https://github.com/OP-TEE/manifest/blob/2.5.0-rc2/hikey_debian_stable.xml) fails for me:

Downloading Debian root fs ...
wget http://builds.96boards.org/snapshots/reference-platform/debian-iot/latest/hikey/hikey-rootfs-debian-stretch-iot-20170331-56.emmc.img.gz -O /home/jerome/work/optee_repo_hikey_debian/build/../out/debian_system.img.gz
--2017-07-06 14:16:34--  http://builds.96boards.org/snapshots/reference-platform/debian-iot/latest/hikey/hikey-rootfs-debian-stretch-iot-20170331-56.emmc.img.gz
Resolving builds.96boards.org (builds.96boards.org)... 54.205.27.170
Connecting to builds.96boards.org (builds.96boards.org)|54.205.27.170|:80... connected.
HTTP request sent, awaiting response... 404 NOT FOUND
2017-07-06 14:16:35 ERROR 404: NOT FOUND.

Makefile:305: recipe for target 'system-img' failed
make: *** [system-img] Error 8

@vchong any idea which URL should be used? (anything with "latest" and a date/version number looks suspicious...)

igoropaniuk · 2017-07-06T12:27:46Z

For tag 2.5.0-rc2:

root@RPi3:/bin ./xtest -l 15
+-----------------------------------------------------
47112 subtests of which 0 failed
78 test cases of which 0 failed
0 test case was skipped
TEE test application done!

Tested-by: Igor Opaniuk <igor.opaniuk@linaro.org> (RPi3)

etienne-lms · 2017-07-06T12:34:19Z

For tag 2.5.0-rc2:
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260, QEMUv7)

lorc · 2017-07-06T14:45:37Z

For tag 2.5.0-rc2:

Tested-by: Volodymyr Babchuk <vlad.babchuk@gmail.com> (RCAR H3)

+-----------------------------------------------------
47112 subtests of which 0 failed
78 test cases of which 0 failed
0 test case was skipped
TEE test application done!

MrVan · 2017-07-07T03:01:39Z

For tag 2.5.0-rc2:
Tested with running ./xtest
Tested-by: Peng Fan <peng.fan@nxp.com> (imx-mx7dsabresd imx-mx6ulevk imx-mx6ullevk)

jbech-linaro · 2017-07-07T08:37:51Z

CHANGELOG.md

@@ -1,3 +1,130 @@
+# OP-TEE - version 2.5.0-rc1


Don't forget to change this later when doing the merge.

Oops, yes thank you

etienne-lms · 2017-07-07T08:49:17Z

minor: @jforissier, few T-b tag are missing some diamonds around mail address in the commit message you are forging.

Tested-by: Jens Wiklander <jens.wiklander@linaro.org> Juno AArch{32,64} Tested-by: Jens Wiklander <jens.wiklander@linaro.org> Juno AArch{32,64} pager Tested-by: Andrew F. Davis <afd@ti.com> (ti-dra7xx, ti-am57xx, ti-am43xx) Tested-by: Igor Opaniuk <igor.opaniuk@linaro.org> (RPi3) Tested-by: Joakim Bech <joakim.bech@linaro.org> (MTK8173) Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (hikey 32/64, GP) Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (hikey 32/64 pager, GP) Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260, GP) Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (cannes2, GP) Tested-by: Sumit Garg <sumit.garg@nxp.com> (ls1021atwr-single-core) Tested-by: Volodymyr Babchuk <vlad.babchuk@gmail.com> (RCAR H3) Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (D02) Tested by: Victor Chong <victor.chong@linaro.org> (hikey aosp) Tested-by: Peng Fan <peng.fan@nxp.com> (imx-mx7dsabresd imx-mx6ulevk imx-mx6ullevk) Tested-by: Sören Brinkmann <soren.brinkmann@xilinx.com> (zynqmp) Tested-by: Joakim Bech <joakim.bech@linaro.org> (Juno, QEMUv7, QEMUv8, FVP, MTK8173)

jforissier · 2017-07-07T09:07:12Z

@etienne-lms right, will fix.

jforissier · 2017-07-07T09:36:41Z

Merged. Thanks everyone for testing!

jenswi-linaro reviewed Jun 29, 2017

View reviewed changes

etienne-lms reviewed Jun 29, 2017

View reviewed changes

igoropaniuk reviewed Jul 5, 2017

View reviewed changes

MrVan reviewed Jul 6, 2017

View reviewed changes

jforissier force-pushed the changelog-2.5.0 branch from 409da12 to 8b2665f Compare July 7, 2017 08:26

jbech-linaro reviewed Jul 7, 2017

View reviewed changes

jforissier force-pushed the changelog-2.5.0 branch from 8b2665f to 7a590e3 Compare July 7, 2017 08:44

jforissier force-pushed the changelog-2.5.0 branch from 7a590e3 to 5d8aaa0 Compare July 7, 2017 09:07

jforissier merged commit 5d8aaa0 into OP-TEE:master Jul 7, 2017

jforissier deleted the changelog-2.5.0 branch July 7, 2017 09:36

Update CHANGELOG.md for 2.5.0 #1649

Update CHANGELOG.md for 2.5.0 #1649

Conversation

jforissier commented Jun 29, 2017

jenswi-linaro Jun 29, 2017

Choose a reason for hiding this comment

sorenb-xlnx commented Jun 29, 2017

jenswi-linaro commented Jun 29, 2017

etienne-lms Jun 29, 2017

Choose a reason for hiding this comment

glneo commented Jun 29, 2017

jenswi-linaro commented Jun 30, 2017

igoropaniuk commented Jun 30, 2017

jbech-linaro commented Jun 30, 2017

jforissier commented Jun 30, 2017

etienne-lms commented Jun 30, 2017 • edited Loading

etienne-lms commented Jun 30, 2017

b49020 commented Jun 30, 2017

lorc commented Jun 30, 2017 • edited Loading

jforissier commented Jun 30, 2017

vchong commented Jul 1, 2017

MrVan commented Jul 3, 2017

jbech-linaro commented Jul 3, 2017

jenswi-linaro commented Jul 3, 2017

etienne-lms commented Jul 3, 2017

jbech-linaro commented Jul 3, 2017

etienne-lms commented Jul 3, 2017

etienne-lms commented Jul 3, 2017

igoropaniuk Jul 5, 2017

Choose a reason for hiding this comment

jforissier Jul 5, 2017

Choose a reason for hiding this comment

etienne-lms commented Jul 5, 2017 • edited Loading

jforissier commented Jul 5, 2017

sorenb-xlnx commented Jul 5, 2017

jforissier commented Jul 5, 2017

etienne-lms commented Jul 5, 2017

jbech-linaro commented Jul 5, 2017 via email • edited Loading

MrVan Jul 6, 2017

Choose a reason for hiding this comment

etienne-lms commented Jul 6, 2017 • edited Loading

etienne-lms commented Jul 6, 2017

jforissier commented Jul 6, 2017

jbech-linaro commented Jul 6, 2017

vchong commented Jul 6, 2017

jbech-linaro commented Jul 6, 2017

jforissier commented Jul 6, 2017

jforissier commented Jul 6, 2017

igoropaniuk commented Jul 6, 2017

etienne-lms commented Jul 6, 2017

lorc commented Jul 6, 2017

MrVan commented Jul 7, 2017

jbech-linaro Jul 7, 2017

Choose a reason for hiding this comment

jforissier Jul 7, 2017

Choose a reason for hiding this comment

etienne-lms commented Jul 7, 2017

jforissier commented Jul 7, 2017

jforissier commented Jul 7, 2017

etienne-lms commented Jun 30, 2017 •

edited

Loading

lorc commented Jun 30, 2017 •

edited

Loading

etienne-lms commented Jul 5, 2017 •

edited

Loading

jbech-linaro commented Jul 5, 2017 via email •

edited

Loading

etienne-lms commented Jul 6, 2017 •

edited

Loading