Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu_v8: clone DTC source #57

Merged
merged 1 commit into from
Jul 5, 2017
Merged

qemu_v8: clone DTC source #57

merged 1 commit into from
Jul 5, 2017

Conversation

jforissier
Copy link
Contributor

Ubuntu 1.4.04 LTS, 16.04 LTS and even 17.04 provide the libfdt in
version 1.4.0. This version is too old for the latest QEMU that
requires libfdt in version 1.4.2 or higher.

This change updates qemu_v8.xml so that the qemu/dtc/ source code is
cloned locally and therefore the build does not depend on libfdt.

Signed-off-by: Jerome Forissier jerome.forissier@linaro.org

@jforissier
Copy link
Contributor Author

I chose not to update default.xml (QEMU) and travis.xml because they use older versions of QEMU, so the change is not needed. The DTC project should be added when these manifests are upgraded to use a newer version of QEMU.

@igoropaniuk
Copy link
Contributor

Although I'm in favor of using built-in support of git submodules in repo (sync-s="true" attribute,which I've mentioned in the previous PR) :)

Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>

@jforissier
Copy link
Contributor Author

@igoropaniuk fine, but do you have a solution to avoid cloning ~138 MiB worth of useless submodules when we need only dtc which is ~858 KiB?

@igoropaniuk
Copy link
Contributor

@jforissier

but do you have a solution to avoid cloning ~138 MiB

Seems that I missed these details :)

Sure, now I totally agree with your solution

Ubuntu 1.4.04 LTS, 16.04 LTS and even 17.04 provide the libfdt in
version 1.4.0. This version is too old for the latest QEMU that
requires libfdt in version 1.4.2 or higher.

This change updates qemu_v8.xml so that the qemu/dtc/ source code is
cloned locally and therefore the build does not depend on libfdt.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants