Repeatable fields in eForms Notice Editor (Physical model)

[AlexAS81]

We are testing the "Generate XML" functionality of the eforms notice editor and we see that the repeatable elements do appear in the visual model, but the same does not happen in the physical model.

For example for the field "Buyer":

Visual model:

"contentId": "GR-ContractingAuthority", "contentType": "group", "contentCount": "1", "children": [ { "contentId": "OPT-300-Procedure-Buyer", "contentType": "field", "contentCount": "1", "visType": "field", "value": "ORG-0001" }, { "contentId": "BT-11-Procedure-Buyer", "contentType": "field", "contentCount": "1", "visType": "field", "value": "body-pl" }, { "contentId": "BT-10-Procedure-Buyer", "contentType": "field", "contentCount": "1", "visType": "field", "value": "defence" }, { "contentId": "BT-508-Procedure-Buyer", "contentType": "field", "contentCount": "1", "visType": "field", "value": "1111" }, { "contentId": "GR-Procedure-SProvider", "contentType": "group", "contentCount": "1", "children": [ { "contentId": "OPT-300-Procedure-SProvider", "contentType": "field", "contentCount": "1", "visType": "field", "value": "ORG-0001" }, { "contentId": "OPT-030-Procedure-SProvider", "contentType": "field", "contentCount": "1", "visType": "field", "value": "ted-esen" } ], "visType": "non-field", "visNodeId": "ND-ServiceProviderParty" }, { "contentId": "GR-Procedure-SProvider", "contentType": "group", "contentCount": "2", "children": [ { "contentId": "OPT-300-Procedure-SProvider", "contentType": "field", "contentCount": "2", "visType": "field", "value": "ORG-0001" }, { "contentId": "OPT-030-Procedure-SProvider", "contentType": "field", "contentCount": "2", "visType": "field", "value": "serv-prov" } ], "visType": "non-field", "visNodeId": "ND-ServiceProviderParty" } ], "visType": "non-field", "visNodeId": "ND-ContractingParty" }, { "contentId": "GR-ContractingAuthority", "contentType": "group", "contentCount": "2", "children": [ { "contentId": "OPT-300-Procedure-Buyer", "contentType": "field", "contentCount": "2", "visType": "field", "value": "ORG-0001" }, { "contentId": "BT-11-Procedure-Buyer", "contentType": "field", "contentCount": "2", "visType": "field", "value": "def-cont" }, { "contentId": "BT-10-Procedure-Buyer", "contentType": "field", "contentCount": "2", "visType": "field", "value": "defence" }, { "contentId": "BT-508-Procedure-Buyer", "contentType": "field", "contentCount": "2", "visType": "field", "value": "2222" }, { "contentId": "GR-Procedure-SProvider", "contentType": "group", "contentCount": "3", "children": [ { "contentId": "OPT-300-Procedure-SProvider", "contentType": "field", "contentCount": "3", "visType": "field", "value": "" }, { "contentId": "OPT-030-Procedure-SProvider", "contentType": "field", "contentCount": "3", "visType": "field", "value": "" } ], "visType": "non-field", "visNodeId": "ND-ServiceProviderParty" } ], "visType": "non-field", "visNodeId": "ND-ContractingParty" }

Physical model:

<cac:ContractingParty> <cac:Party> <cac:PartyIdentification> <cbc:ID>ORG-0001</cbc:ID> </cac:PartyIdentification> </cac:Party> <cac:ServiceProviderParty> <cac:Party> <cac:PartyIdentification> <cbc:ID/> </cac:PartyIdentification> </cac:Party> <cbc:ServiceTypeCode listName="organisation-role-service"/> </cac:ServiceProviderParty> <cac:ContractingPartyType> <cbc:PartyTypeCode listName="eforms-buyer-legal-type">body-pl</cbc:PartyTypeCode> <cbc:PartyTypeCode listName="eforms-buyer-legal-type">def-cont</cbc:PartyTypeCode> </cac:ContractingPartyType> <cac:ContractingActivity> <cbc:ActivityTypeCode listName="authority-activity">defence</cbc:ActivityTypeCode> </cac:ContractingActivity> <cbc:BuyerProfileURI>2222</cbc:BuyerProfileURI> </cac:ContractingParty>

Is it because we have not completed the file correctly or the generation of repeatable fields in the generation of the physical model is not fully operational?

Thanks in advance,
Alex

[YvesJo]

Hi Alex,
Buyer is repeatable and so does cac:ContractingParty

Also do not use a same organization identifier (ORG-0001) to designate organizations with "conflicting" roles as this is confusing (I see that ORG-0001 is providing services to ORG-0001).
Empty elements should be removed from the generated XML.
I wish this helps
KR
Yves

[AlexAS81]

Could you tell me which repetitive field of the eForms Notice Editor Demo form appears repetitively and correctly in the physical model when using the "Generate XML" functionality?

[rouschr]

See my answer.

[rouschr]

Please provide the used SDK version and the chosen notice subtype (1, 2, 3, T01, ..?) and which branch of the editor you are using.
Did you load this XML from an existing notice or did you create it fully using an empty form?
Ideally I also need a minimal reproducible case (MRE), just the full visual model json would help a lot.
Otherwise I will have trouble reproducing it.

The visual model looks OK.
The first value is for "TED eSender" is:

"children": [
 { "contentId": "OPT-300-Procedure-SProvider", "contentType": "field", "contentCount": "1", 
 "visType": "field", "value": "ORG-0001" }, 
 { "contentId": "OPT-030-Procedure-SProvider", "contentType": "field", "contentCount": "1", 
 "visType": "field", "value": "ted-esen" } 
 ]

The second value for "Procurement Service Provider" is:

 { "contentId": "OPT-300-Procedure-SProvider", "contentType": "field", "contentCount": "2", 
 "visType": "field", "value": "ORG-0001" }, 
 { "contentId": "OPT-030-Procedure-SProvider", "contentType": "field", "contentCount": "2", 
 "visType": "field", "value": "serv-prov" }

I see that you have a problem inside required fields, it is possible that an invalid / incomplete form cannot be correctly transformed to XML as sometimes xpath (predicates...) depends on various required fields to work.
It is also possible this particular form has a case which was not seen yet, like a problematic xpath or something wrong in the notice type definitions.

There is a minimal "self-contained" unit test showing how nested repetition is handled, not that it relies on a dummy test SDK:
https://github.com/OP-TED/eforms-notice-editor/blob/develop/src/test/java/eu/europa/ted/eforms/noticeeditor/helper/notice/SaveNoticeRepeatableTest.java
https://github.com/OP-TED/eforms-notice-editor/tree/develop/src/test/resources/dummy-sdk/1.5.0

[AlexAS81]

We have generated new physical an visual (with repeatable elements) models.

The element ND-ProcedureAdditionalCommodityClassification (BT-26) appears twice in the visual mode.

[rouschr]

We have generated new physical an visual (with repeatable elements) models.

How did you generate the json, did you generate it yourself by modifying something or does it come exactly from the editor demo.

[AlexAS81]

Iit comes exactly from the editor demo.

[AlexAS81]

Which github branch is best to test the eForms Notice Editor application with?

[rouschr]

Currently it is the "develop" branch, make sure you do a git pull because we may update it at any time with the latest developments.
In the future the editor demo projects will have proper versioning and I hope to add more tests (maybe integration tests).
The current unit tests are not taking the front-end part into account, they test Java code in isolation.
The editor demo may be lagging a bit behind the latest SDK features, but sometimes we first work on the editor demo to test SDK features to see how usable they are in practice and later work on the SDK to implement them.