next/195/20231120/v1 #9847
Merged
next/195/20231120/v1 #9847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To mitigate a bug with AF_XDP sockets in high traffic scenarios, the XDP program must be detatched before the sockets are closed. This issue happens when large ammounts of traffic are sent to suricata and the XDP program is not removed before AF_XDP sockets are closed. I believe this is a race condition bug as detailed here: https://bugzilla.kernel.org/show_bug.cgi?id=217712 Further investigation shows this may be a bug exclusive to the driver/AMD processor combination. This commit addresses the bug by ensuring the first thread to run the deinit function removes the XDP program, which fixes the bug as detailed in the bugzilla link. Bug OISF#6238
Ticket: 6290
Ticket: OISF#4083
|
NOTE: This PR may contain new authors. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9847 +/- ##
==========================================
- Coverage 82.47% 82.46% -0.01%
==========================================
Files 972 973 +1
Lines 273932 273962 +30
==========================================
+ Hits 225915 225931 +16
- Misses 48017 48031 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Nov 20, 2023
This was referenced Nov 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=pr/1486