-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signature: avoids overflow from VariableNameHash #4083
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Jul 19, 2023
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Aug 30, 2023
Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Aug 30, 2023
+ remove double definition of IPPairLock Ticket: OISF#4083
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Aug 30, 2023
Ticket: OISF#4083
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Aug 30, 2023
Ticket: OISF#4083
jasonish
pushed a commit
to jasonish/suricata
that referenced
this pull request
Aug 31, 2023
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Sep 18, 2023
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Sep 18, 2023
Ticket: OISF#4083
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Nov 17, 2023
Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Nov 19, 2023
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Nov 19, 2023
Ticket: OISF#4083
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Nov 20, 2023
Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Dec 21, 2023
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Dec 21, 2023
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Feb 12, 2024
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Mar 21, 2024
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Mar 21, 2024
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Apr 12, 2024
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Apr 12, 2024
+ remove double definition of IPPairLock Ticket: OISF#4083
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Apr 12, 2024
+ remove double definition of IPPairLock Ticket: OISF#4083
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Apr 13, 2024
+ remove double definition of IPPairLock Ticket: OISF#4083
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None
Describe changes:
VariableNameHash
not limiting its hash sizeFound by fuzzing
SigInit
Stack trace is following
==12==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x62d000030400 at pc 0x000000ae8bc6 bp 0x7ffd627f4a30 sp 0x7ffd627f4a28
READ of size 8 at 0x62d000030400 thread T0 (Suricata-Main)
SCARINESS: 23 (8-byte-read-heap-buffer-overflow)
#0 0xae8bc5 in HashListTableAdd /src/suricata/src/util-hashlist.c:135:9
#1 0xb9f0d5 in VariableNameGetIdx /src/suricata/src/util-var-name.c:193:9
#2 0xb9ed4f in VarNameStoreSetupAdd /src/suricata/src/util-var-name.c:324:10
#3 0x7e7f27 in DetectFlowbitSetup /src/suricata/src/detect-flowbits.c:249:15
#4 0x855dad in SigParseOptions /src/suricata/src/detect-parse.c:742:13
#5 0x84df20 in SigParse /src/suricata/src/detect-parse.c:1174:19
#6 0x84a55a in SigInitHelper /src/suricata/src/detect-parse.c:1798:9
#7 0x849fbe in SigInit /src/suricata/src/detect-parse.c:1944:16