-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: remove unused #9498
rust: remove unused #9498
Conversation
Ticket: OISF#4083
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9498 +/- ##
==========================================
- Coverage 82.18% 82.17% -0.02%
==========================================
Files 968 968
Lines 274203 274200 -3
==========================================
- Hits 225352 225321 -31
- Misses 48851 48879 +28
Flags with carried forward coverage won't be shown. Click here to find out more. |
WARNING:
Pipeline 15992 |
Information: QA ran without warnings. Pipeline 16043 |
@@ -38,54 +38,12 @@ pub const DCERPC_UUID_ENTRY_FLAG_FF: u16 = 0x0001; | |||
pub const PFC_FIRST_FRAG: u8 = 0x01; | |||
// Value to indicate last fragment | |||
pub const PFC_LAST_FRAG: u8 = 0x02; | |||
// Cancel was pending at sender |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see defines like this as dead code, would rather have them stay. It will make things easier when support is added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use a rather Rusty convention and prefix with with _
so its clear to the reader they are not used? And perhaps awaiting use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would work for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comments
Going on with #9842 |
Link to redmine ticket:
None, generic cleaning
https://redmine.openinfosecfoundation.org/issues/4083
Describe changes:
Found with
git grep 'pub ' rust/src/ | cut -d: -f1 | uniq | xargs sed -i -e 's/pub /pub(crate) /'
then see rust warnings when compilingThere is nothing more to be done :
rrclass
in DNSQueryEntry) : I feel good to keep themRebase #9419