rust: remove unused #9498
Closed
rust: remove unused #9498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: OISF#4083
Closed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9498 +/- ##
==========================================
- Coverage 82.18% 82.17% -0.02%
==========================================
Files 968 968
Lines 274203 274200 -3
==========================================
- Hits 225352 225321 -31
- Misses 48851 48879 +28
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 15992 |
jasonish
approved these changes
Sep 19, 2023
|
Information: QA ran without warnings. Pipeline 16043 |
| @@ -38,54 +38,12 @@ pub const DCERPC_UUID_ENTRY_FLAG_FF: u16 = 0x0001; | |||
| pub const PFC_FIRST_FRAG: u8 = 0x01; | |||
| // Value to indicate last fragment | |||
| pub const PFC_LAST_FRAG: u8 = 0x02; | |||
| // Cancel was pending at sender | |||
There was a problem hiding this comment.
I don't really see defines like this as dead code, would rather have them stay. It will make things easier when support is added.
There was a problem hiding this comment.
Could we use a rather Rusty convention and prefix with with _ so its clear to the reader they are not used? And perhaps awaiting use?
Closed
Closed
|
Going on with #9842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None, generic cleaning
https://redmine.openinfosecfoundation.org/issues/4083
Describe changes:
Found with
git grep 'pub ' rust/src/ | cut -d: -f1 | uniq | xargs sed -i -e 's/pub /pub(crate) /'then see rust warnings when compilingThere is nothing more to be done :
rrclassin DNSQueryEntry) : I feel good to keep themRebase #9419