Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Ish/Staging/v1 #9421

Closed
wants to merge 6 commits into from
Closed

Draft: Ish/Staging/v1 #9421

wants to merge 6 commits into from

Commits on Aug 30, 2023

  1. rust: remove unused

    Ticket: OISF#4083
    catenacyber authored and jasonish committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    4a0f875 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e89f8c9 View commit details
    Browse the repository at this point in the history
  3. rdp: do not use zero-bit bitflag

    catenacyber authored and jasonish committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    4788cda View commit details
    Browse the repository at this point in the history
  4. rust: update bitflags crate + cargo update

    Update the Bitflags crate to the latest supported version. This fixes
    up a new clippy warning:
    
    error: &-masking with zero
       --> src/rdp/parser.rs:161:1
        |
    161 | / bitflags! {
    162 | |     pub struct ProtocolFlags: u32 {
    163 | |         const PROTOCOL_RDP = Protocol::ProtocolRdp as u32;
    164 | |         const PROTOCOL_SSL = Protocol::ProtocolSsl as u32;
    ...   |
    168 | |     }
    169 | | }
        | |_^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask
        = note: `#[deny(clippy::bad_bit_mask)]` on by default
        = note: this error originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info)
    jasonish committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    6b6c598 View commit details
    Browse the repository at this point in the history
  5. community-id: Fix IPv6 address sorting not respecting byte order

    When comparing IPv6 addresses based on uint32_t chunks, one needs to
    apply ntohl() conversion to the individual parts, otherwise on little
    endian systems individual bytes are compared in the wrong order.
    Avoid this all and leverage memcmp(), it'll short circuit on the first
    differing byte and its return values tells us which address sorts lower.
    
    Bug: OISF#6276
    awelzel authored and jasonish committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    ccefbd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. iprep: fix parsing ip-rep data with carriage return

    Commit e7c0f0a removed uses of atoi with a new number parsing
    functions. This broke parsing ip-reputation data files that contained
    trailing carriage returns as it was being included in the number
    string to convert.
    
    Bug: OISF#6243.
    thomasjwinter authored and jasonish committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    6164b64 View commit details
    Browse the repository at this point in the history