-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc/v1 #9313
Misc/v1 #9313
Conversation
Normalize the timestamps that are too far in the past to epoch. Bug: OISF#6240.
Data on RST packets is not invalid, but also shouldn't be used in reassembly. RFC 1122: 4.2.2.12 RST Segment: RFC-793 Section 3.4 A TCP SHOULD allow a received RST segment to include data. DISCUSSION It has been suggested that a RST segment could contain ASCII text that encoded and explained the cause of the RST. No standard has yet been established for such data. RST data will be presented to the detection engine per packet, but will not be part of stream reassembly. Bug: OISF#6244.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9313 +/- ##
==========================================
- Coverage 82.41% 82.39% -0.03%
==========================================
Files 968 968
Lines 274055 274064 +9
==========================================
- Hits 225872 225818 -54
- Misses 48183 48246 +63
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 15468 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. Is ther an S-V test for the data on reset cases?
Merged in #9320, thanks! |
|
No description provided.