Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next/93/20230721/v3 #9267

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Next/93/20230721/v3 #9267

merged 2 commits into from
Jul 21, 2023

Conversation

victorjulien
Copy link
Member

catenacyber and others added 2 commits July 19, 2023 22:00
@catenacyber
decode: fix offset for DCE layer
fdf9cdf 
Fixes: 136d351 ("decode: single network layer entrypoint")

Ticket: OISF#3637
@coledishington @victorjulien
decode-ipv6: Set L4 proto on ipv6 incase of GRE decode error
1b08c56 
Set the L4 proto before decoding GRE in ipv6 decoding in case there is a
GRE header decoding error.

Bug: OISF#6222
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #9267 (1b08c56) into master (9a33c53) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9267      +/-   ##
==========================================
- Coverage   82.42%   82.42%   -0.01%     
==========================================
  Files         968      968              
  Lines      273952   273953       +1     
==========================================
- Hits       225807   225798       -9     
- Misses      48145    48155      +10
Flag Coverage Δ
fuzzcorpus 64.71% <100.00%> (+0.02%) ⬆️
suricata-verify 60.80% <100.00%> (-0.01%) ⬇️
unittests 62.93% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPW2_autofp_stats_chk
.flow.spare 1936156 1834110 94.73%

Pipeline 15347

@victorjulien victorjulien merged commit 1b08c56 into OISF:master Jul 21, 2023
51 of 52 checks passed
@victorjulien victorjulien mentioned this pull request Jul 21, 2023
Closed
@victorjulien victorjulien deleted the next/93/20230721/v3 branch August 12, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @suricata-qa @catenacyber @coledishington