Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2798] add http_host to engine analysis #3637

Closed
wants to merge 1 commit into from
Closed

[#2798] add http_host to engine analysis #3637

wants to merge 1 commit into from

Conversation

travisbgreen
Copy link
Contributor

https://redmine.openinfosecfoundation.org/issues/2798

Link to redmine ticket:

Describe changes:

  • Added checks for host_header buffer

@travisbgreen travisbgreen requested a review from a team as a code owner February 1, 2019 20:24
@travisbgreen travisbgreen changed the title Fixes bug #2798, --engine-analysis is unaware of http_host buffer [#2798] add http_host to engine analysis Feb 1, 2019
@victorjulien
Copy link
Member

Code looks good. Would like to see a new version with an improved commit message. My suggestion would be something like:

engine-analysis: add support for http_host buffer

Add support for http_host buffer for more accurate reporting.

Bug: #2798

The subject line is : short description.

Minor other thing: the checkboxes should be fixed up. Removing the spaces does it.

Can you submit a new PR? Thanks!

catenacyber added a commit to catenacyber/suricata that referenced this pull request Jun 30, 2023
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jul 6, 2023
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jul 19, 2023
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jul 19, 2023
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jul 19, 2023
Fixes: 136d351 ("decode: single network layer entrypoint")

Ticket: OISF#3637
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Jul 22, 2023
Fixes: 136d351 ("decode: single network layer entrypoint")

Ticket: OISF#3637
(cherry picked from commit fdf9cdf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants