-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decode: fix offset for DCE layer #9251
Conversation
Can you find the commit that broke things? Would like to understand if it was broken accidentally or that it was attempt to fix something else. |
Btw, my
Then |
Commit 136d351 broke it
base |
8b331da
to
9ad4ade
Compare
I force-pushed the reworded commit. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9251 +/- ##
==========================================
- Coverage 82.42% 82.42% -0.01%
==========================================
Files 968 968
Lines 273952 273952
==========================================
- Hits 225807 225795 -12
- Misses 48145 48157 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3637
Describe changes:
Jason, it looks like your commit 95015a3 was right but got broken in between
Rebase #9153 now that 7 is released to get attention for 7.0.1
OISF/suricata-verify#1289