Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/92/60x/20230718/v1 #9249

Merged
merged 6 commits into from
Jul 19, 2023
Merged

next/92/60x/20230718/v1 #9249

merged 6 commits into from
Jul 19, 2023

Commits on Jul 14, 2023

  1. requirements: use libhtp 0.5.45 

    (cherry picked from commit ce05511)
    @victorjulien @satta
    victorjulien authored and satta committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cedee76 View commit details
    Browse the repository at this point in the history

  2. rfb: be more strict parsing the version 

    (cherry picked from commit bd1fbf3)
    @satta
    satta committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    66d55a7 View commit details
    Browse the repository at this point in the history

  3. rfb: add myself as contributor 

    (cherry picked from commit 836fff3)
    @satta
    satta committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    7a52e39 View commit details
    Browse the repository at this point in the history

  4. rfb: never return error on unknown traffic 

    We only try to parse a small subset of what is possible in
RFB. Currently we only understand some standard auth schemes
and stop parsing when the server-client handshake is complete.
Since in IPS mode returning an error from the parser causes
drops that are likely uncalled for, we do not want to return
errors when we simply do not understand what happens in the
traffic. This addresses Redmine OISF#5912.

Bug: OISF#5915.
(cherry picked from commit 1f8a587)
    @satta
    satta committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    8f1e08b View commit details
    Browse the repository at this point in the history

  5. rfb: ensure logging of incompletely parsed txs 

    (cherry picked from commit 1606aca)
    @satta
    satta committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b1d2d78 View commit details
    Browse the repository at this point in the history

  6. rfb: also set unimplemented auth types 

    (cherry picked from commit 1521b77)
    @satta
    satta committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    74cbbd7 View commit details
    Browse the repository at this point in the history