Backports 602/b3/v1 #5915
Closed
Backports 602/b3/v1 #5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The book defines transmute as "This is really, truly, the most horribly unsafe thing you can do in Rust. The guardrails here are dental floss." Transmute can result into mind boggling undefined behaviors. Get rid of it wherever possible. (cherry picked from commit 0ca8591)
(cherry picked from commit d7a3523)
(cherry picked from commit 3641f1b)
Lately, Wireguard proto starting w pattern |04 00| is misdetected as DCERPC/UDP which also starts with the same pattern, add more checks to make sure that it is the best guess for packet to be dcerpc/udp. (cherry picked from commit f967a49)
(cherry picked from commit c77c8e7)
(cherry picked from commit 0ac5c53)
inashivb
requested review from
jasonish,
victorjulien and
a team
as code owners
|
Merged as part of #5934, thanks! |
satta
added a commit
to satta/suricata
that referenced
this pull request
Jul 13, 2023
We only try to parse a small subset of what is possible in RFB. Currently we only understand some standard auth schemes and stop parsing when the server-client handshake is complete. Since in IPS mode returning an error from the parser causes drops that are likely uncalled for, we do not want to return errors when we simply do not understand what happens in the traffic. This addresses Redmine OISF#5912. Bug: OISF#5915.
satta
added a commit
to satta/suricata
that referenced
this pull request
Jul 14, 2023
We only try to parse a small subset of what is possible in RFB. Currently we only understand some standard auth schemes and stop parsing when the server-client handshake is complete. Since in IPS mode returning an error from the parser causes drops that are likely uncalled for, we do not want to return errors when we simply do not understand what happens in the traffic. This addresses Redmine OISF#5912. Bug: OISF#5915. (cherry picked from commit d0dc924)
satta
added a commit
to satta/suricata
that referenced
this pull request
Jul 14, 2023
We only try to parse a small subset of what is possible in RFB. Currently we only understand some standard auth schemes and stop parsing when the server-client handshake is complete. Since in IPS mode returning an error from the parser causes drops that are likely uncalled for, we do not want to return errors when we simply do not understand what happens in the traffic. This addresses Redmine OISF#5912. Bug: OISF#5915. (cherry picked from commit 1f8a587)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4353
https://redmine.openinfosecfoundation.org/issues/4315
https://redmine.openinfosecfoundation.org/issues/4312
https://redmine.openinfosecfoundation.org/issues/4354