Add commandline option to simulate alert queue expand failure - v3 (again) #7649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For testing purposes. Meant to simulate a reallocation failure when dynamically growing the alert queue in DetectEngineThreadCtx, so we can check that Suri's behavior doesn't break under such circumstances. Task OISF#5319
Codecov Report
@@ Coverage Diff @@
## master #7649 +/- ##
==========================================
+ Coverage 75.75% 79.26% +3.51%
==========================================
Files 659 659
Lines 185743 229933 +44190
==========================================
+ Hits 140713 182265 +41552
- Misses 45030 47668 +2638
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on ips_afp_drop_chk. Pipeline 8334 |
victorjulien
approved these changes
Jul 27, 2022
|
Merged in #7653, thanks! |
|
Seems like this one was left Home Alone :P |
|
I guess you need to rebase and open a new PR as one commit out of 2 was merged |
roger that! Replaced by #7656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same work from #7622 but in a new PR to see how the CI checks perform without the SV tests I wrote to test Suri behavior when the tmp alert queue reallocation fails.
Usage in IPS mode, to simulate a failure for debugging purposes. Command-line arguments:
--simulate-ips --simulate-alert-queue-realloc-failure. This will return the defaultpacket_alert_maxcapacity when Suri tries to expanddet_ctx->alert_queue, instead realloc'ng.