Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commandline option to simulate alert queue expand failure - v3 #7622

Closed
wants to merge 2 commits into from
Closed

Add commandline option to simulate alert queue expand failure - v3 #7622

wants to merge 2 commits into from

Conversation

jufajardini
Copy link
Contributor

@jufajardini jufajardini commented Jul 12, 2022 •
edited
Loading

Previous PR: #7527

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5319

Describe changes:

  • guard the inclusion of util-exception-policy headers within ifdef DEBUG

This shows how to use it: OISF/suricata-verify#850

@jufajardini
commandline: add alert-queue expand failure option
e303ea4 
For testing purposes. Meant to simulate a reallocation failure when
dynamically growing the alert queue in DetectEngineThreadCtx, so we can
check that Suri's behavior doesn't break under such circumstances.

Task OISF#5319
@jufajardini
detect/engine: fix typos in assorted files
c12ae13
This was referenced Jul 12, 2022
Closed
Closed
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 8208

@jufajardini
Copy link
Contributor Author

Forgot to mention that the SV tests are supposed to fail, as we're still improving Suri behavior when the alert queue reallocation fails.

@catenacyber
Copy link
Contributor

Forgot to mention that the SV tests are supposed to fail, as we're still improving Suri behavior when the alert queue reallocation fails.

So, should this be a draft PR ?

@jufajardini
Copy link
Contributor Author

Forgot to mention that the SV tests are supposed to fail, as we're still improving Suri behavior when the alert queue reallocation fails.

So, should this be a draft PR ?

As this is just an option to simulate a failure, I don't think this needs to be a draft. 🤔

@jufajardini
Copy link
Contributor Author

Further discussion with @catenacyber indicates that the SV tests should not be linked in the PR.

@catenacyber
Copy link
Contributor

Further discussion with catenacyber indicates that the SV tests should not be linked in the PR.

Could you edit the first message to remove the S-V PR reference and get CI running again ?

@jufajardini
Copy link
Contributor Author

jufajardini commented Jul 27, 2022 •
edited
Loading

Further discussion with catenacyber indicates that the SV tests should not be linked in the PR.

Could you edit the first message to remove the S-V PR reference and get CI running again ?

It won't let go of the mentioned SV tests, now. Checks on new PR: #7649

@jufajardini jufajardini mentioned this pull request Jul 27, 2022
Closed
@jufajardini jufajardini deleted the alert-expand-fail-5319/v3 branch August 2, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jufajardini @suricata-qa @catenacyber