Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/20200408/v7 #4802

Merged
merged 13 commits into from
Apr 10, 2020
Merged

Next/20200408/v7 #4802

merged 13 commits into from
Apr 10, 2020

Conversation

victorjulien
Copy link
Member

@victorjulien victorjulien commented Apr 10, 2020

#4799 with error msg typo fix
#4796
#4793
#4613
Signature memory leaks on the error path fixed.

https://redmine.openinfosecfoundation.org/issues/3632

PRScript output (if applicable):
Passed

victorjulien and others added 13 commits April 8, 2020 22:45
Expose UTH flow builder to new 'FUZZ' define as well. Move UTHbufferToFile
as well and rename it to a more generic 'TestHelperBufferToFile'.

This way UNITTESTS can be disabled. This leads to smaller code size
and more realistic testing as in some parts of the code things
behave slightly differently when UNITTESTS are enabled.
Only reachable on SCMalloc so should be unlikely to be reached.
A deeply nested YAML file can cause a stack-overflow while
reading in the configuration to do the recursive parser. Limit
the recursion level to something sane (128) to prevent this
from happening.

The default Suricata configuration has a recursion level of 128
so there is still lots of room to grow (not that we should).

Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3630
Make AF_PACKET and PCAP mode use it.
This way new layers can be added in a single place.
So that the caller can set the correct event type on error.
@victorjulien victorjulien requested a review from a team as a code owner April 10, 2020 12:42
@victorjulien victorjulien merged commit a95fa3c into OISF:master Apr 10, 2020
@victorjulien victorjulien deleted the next/20200408/v7 branch April 12, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants