conf/yaml: limit recursion depth while paring YAML - v1 #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A deeply nested YAML file can cause a stack-overflow while reading in the configuration to do the recursive parser. Limit the recursion level to something sane (128) to prevent this from happening. The default Suricata configuration has a recursion level of 128 so there is still lots of room to grow (not that we should). Redmine ticket: https://redmine.openinfosecfoundation.org/issues/3630
jasonish
force-pushed
the
conf-yaml-recursion-limit/v1
branch
from
06259ab
to
6913ccf
Compare
satta
reviewed
Apr 10, 2020
| int retval = 0; | ||
|
|
||
| if (rlevel++ > RECURSION_LIMIT) { | ||
| FatalError(SC_ERR_FATAL, "Recusion limit hit while parsing configuration file, aborting."); |
There was a problem hiding this comment.
FYI: There's a typo here: Recusion.
There was a problem hiding this comment.
Thanks, fixing this before merge.
Merged
|
Merged with typo-fix in #4802, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A deeply nested YAML file can cause a stack-overflow while
reading in the configuration to do the recursive parser. Limit
the recursion level to something sane (128) to prevent this
from happening.
The default Suricata configuration has a recursion level of 128
so there is still lots of room to grow (not that we should).
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3630
PRScript output (if applicable):