Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applayer/htp: convert to new FAIL/PASS API-v7 #12023

Conversation

Nancyenos
Copy link
Contributor

@Nancyenos Nancyenos commented Oct 23, 2024

Ticket: #6935

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6935

Describe changes:

  • convert applayer/htp to new FAIL/PASS API

-previous pr #12017

@Nancyenos Nancyenos changed the title applayer/htp: convert to new FAIL/PASS API applayer/htp: convert to new FAIL/PASS API-v7 Oct 23, 2024
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 23, 2024
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 🎉 kudos for the resilience! :P

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 99.45652% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.75%. Comparing base (1860aa8) to head (b118cba).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12023      +/-   ##
==========================================
- Coverage   83.24%   79.75%   -3.50%     
==========================================
  Files         910      910              
  Lines      258136   257443     -693     
==========================================
- Hits       214895   205323    -9572     
- Misses      43241    52120    +8879     
Flag Coverage Δ
fuzzcorpus 61.49% <ø> (ø)
livemode 19.38% <ø> (ø)
pcap 44.40% <ø> (-0.03%) ⬇️
suricata-verify ?
unittests 59.37% <99.45%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Oct 24, 2024
@victorjulien
Copy link
Member

Merged in #12026, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

3 participants