Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applayer/htp: convert to new FAIL/PASS API-v6 #12017

Conversation

Nancyenos
Copy link
Contributor

@Nancyenos Nancyenos commented Oct 23, 2024

Ticket: #6935

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6935

Describe changes:
-convert applayer/htp: convert to new FAIL/PASS API
-previous pr #11973

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 23, 2024
Copy link

NOTE: This PR may contain new authors.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 99.46092% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (30806ce) to head (f95a9e4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12017      +/-   ##
==========================================
+ Coverage   83.22%   83.38%   +0.16%     
==========================================
  Files         910      910              
  Lines      258136   257620     -516     
==========================================
- Hits       214831   214826       -5     
+ Misses      43305    42794     -511     
Flag Coverage Δ
fuzzcorpus 61.49% <ø> (+0.08%) ⬆️
livemode 19.38% <ø> (+<0.01%) ⬆️
pcap 44.45% <ø> (-0.01%) ⬇️
suricata-verify 62.75% <ø> (+<0.01%) ⬆️
unittests 59.37% <99.46%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there, good job with such a big first contrib!

I think that if you address the three inline comments that I've left that require changes, the next version should be ready for merging :)

src/app-layer-htp.c Show resolved Hide resolved
src/app-layer-htp.c Show resolved Hide resolved
Comment on lines +3584 to +3587
FAIL_IF_NULL(tx_ud);
FAIL_IF_NULL(tx_ud->request_uri_normalized);
PrintRawDataFp(stdout, bstr_ptr(tx_ud->request_uri_normalized),
bstr_len(tx_ud->request_uri_normalized));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this changes the original test a bit, considering that all unittests are still passing, my assumption is that this is a valid representation, still.

Leaving this note here to set the expectations, in case someone else sees and asks for this to be changed (but I don't think anyone will, since tests are passing)

src/app-layer-htp.c Show resolved Hide resolved
src/app-layer-htp.c Show resolved Hide resolved
@Nancyenos
Copy link
Contributor Author

Nancyenos commented Oct 23, 2024

We're almost there, good job with such a big first contrib!

I think that if you address the three inline comments that I've left that require changes, the next version should be ready for merging :)

Let me address them just now, cant wait to see this contribution merged! its been a long road

@Nancyenos
Copy link
Contributor Author

work continued in #12023

@Nancyenos Nancyenos closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

2 participants