-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applayer/htp: convert to new FAIL/PASS API v-3 #11950
applayer/htp: convert to new FAIL/PASS API v-3 #11950
Conversation
NOTE: This PR may contain new authors. |
|
||
end: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code from the old end block will be unreachable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11950 +/- ##
===========================================
- Coverage 82.56% 74.84% -7.72%
===========================================
Files 912 846 -66
Lines 249354 149089 -100265
===========================================
- Hits 205880 111592 -94288
+ Misses 43474 37497 -5977
Flags with carried forward coverage won't be shown. Click here to find out more. |
Please also rebase your PR on top of the latest master branch. |
Than you for the review.working on it |
Ticket: #6935
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Describe changes:
-previous pr Convert unittests to new fail pass api v 2 #11941
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCH
variable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=