Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applayer/htp: convert to new FAIL/PASS API v-3 #11950

Conversation

Nancyenos
Copy link
Contributor

@Nancyenos Nancyenos commented Oct 13, 2024

Ticket: #6935

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/

Describe changes:

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Copy link

NOTE: This PR may contain new authors.


end:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code from the old end block will be unreachable

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.84%. Comparing base (501f79c) to head (5f5b85a).
Report is 38 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (501f79c) and HEAD (5f5b85a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (501f79c) HEAD (5f5b85a)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11950       +/-   ##
===========================================
- Coverage   82.56%   74.84%    -7.72%     
===========================================
  Files         912      846       -66     
  Lines      249354   149089   -100265     
===========================================
- Hits       205880   111592    -94288     
+ Misses      43474    37497     -5977     
Flag Coverage Δ
fuzzcorpus 60.83% <ø> (+0.37%) ⬆️
livemode 18.70% <ø> (-0.03%) ⬇️
pcap 44.10% <ø> (+0.01%) ⬆️
suricata-verify 62.17% <ø> (+0.16%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@inashivb
Copy link
Member

Please also rebase your PR on top of the latest master branch.

@Nancyenos
Copy link
Contributor Author

Than you for the review.working on it

@Nancyenos Nancyenos closed this Oct 14, 2024
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

4 participants