Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert unittests to new fail pass api v 2 #11941

Conversation

Nancyenos
Copy link
Contributor

@Nancyenos Nancyenos commented Oct 11, 2024

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6935

Describe changes:

-converted applayer/htp to new FAIL/PASS API

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

@victorjulien
Copy link
Member

Please make sure to create a clean set of git commits, so no merge commits, no commits fixing other commits in the PR, etc.

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline

Also, please make sure to fill in the PR template correctly.

@Nancyenos
Copy link
Contributor Author

okay well noted..getting on it

@Nancyenos
Copy link
Contributor Author

Nancyenos commented Oct 12, 2024

do i just close this pr?

Nancyenos

This comment was marked as off-topic.

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 14, 2024
@jufajardini
Copy link
Contributor

do i just close this pr?

I'll answer this as it's useful for future reference ;)
When you have changes requested in a PR, you can leave it open while you work on a new version. Once you have opened a new PR, you can close the older one, with a reference to the follow up PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

3 participants