detect/requires: reset sigerror flags for each rule #10237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"sigerror_ok" and "sigerror_requires" were not being reset after each rule which could lead to a rule load error being incorrectly tracked as skipped rather than failed. Also initialize "skippedsigs" to 0 along with "goodsigs" and "badsigs", while not directly related to this issue, could also throw off some stats. Ticket: OISF#6710
|
CI error does not seem related: ===> http-not09: Sub test #1: FAIL : expected 1 matches; got 0 for filter {'count': 1, 'match': {'event_type': 'http', 'http.http_user_agent': 'myscript'}} |
|
Information: ERROR: QA failed on SURI_TLPW1_files_sha256.
Pipeline 17732 |
victorjulien
approved these changes
Jan 25, 2024
inashivb
reviewed
Jan 25, 2024
| de_ctx->sigerror_silent = false; | ||
| de_ctx->sigerror_requires = false; |
There was a problem hiding this comment.
This is a better solution than what I had proposed. Looks great!
This was referenced Jan 25, 2024
Closed
Merged
|
Merged in #10244, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where a bad rule after a skipped rule was recorded as skipped.
Also add a note about which version of Suricata contain this keyword.
Ticket: https://redmine.openinfosecfoundation.org/issues/6710
SV_BRANCH=OISF/suricata-verify#1610