Long table name error hotfix #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 30, 2019 15:03
…aming If a worksheet name clash occurs, the variable analysis is not exported.
blootsvoets
reviewed
Jul 30, 2019
whiterabbit/src/main/java/org/ohdsi/whiteRabbit/scan/SourceDataScan.java
Outdated
Show resolved
Hide resolved
added 3 commits
July 30, 2019 17:08
blootsvoets
approved these changes
Jul 31, 2019
whiterabbit/src/main/java/org/ohdsi/whiteRabbit/scan/SourceDataScan.java
Outdated
Show resolved
Hide resolved
|
One thing that is mentioned in #113 is to remove the '.csv.' extension from filenames. While I think this is in general useful, it could create clashes in file name uniqueness (e.g. same filename, but with .csv and .txt extension). This then again creates similar problems with RiaH not being able to find the field values. |
schuemie
approved these changes
Aug 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for issues #14 and #113, where long table names causes errors in WR scans.
This fix prevents RiaH from crashing by skipping the second table when a tab name clash occurs. It presents user with a warning when this happens.