Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Name Length #113

Closed
ericaVoss opened this issue Sep 6, 2016 · 3 comments
Closed

Table Name Length #113

ericaVoss opened this issue Sep 6, 2016 · 3 comments
Labels

Comments

@ericaVoss
Copy link
Contributor

Need to do some error handling around table name length.

If you don't limit table names to 31 characters you end up with some issues. MS Excel only displays 31 characters in the tab name. If the name of the table ends up being longer than 31, Rabbit In a Hat cannot connect the table name to the tab with the data in it.

For Example, when scanning the Synpuf CSVs:

  • Original File Name: DE1_0_2008_to_2010_Prescription_Drug_Events_Sample_1
  • File Name Scanned: 2008_to_2010_Prescription_Drug_Events_1
  • Tab Name: 2008_to_2010_Prescription_Drug_
@ericaVoss
Copy link
Contributor Author

You can trim .CSV out of the names by default.

@schuemie schuemie added the bug label Nov 8, 2017
@schuemie
Copy link
Member

schuemie commented Nov 8, 2017

Appears related to this issue.

MaximMoinat pushed a commit that referenced this issue Aug 13, 2019
Preventing sheet name clashes for long tables. Closes #14 and #113
@MaximMoinat
Copy link
Collaborator

Fixed through PR #162. Trimming of file extension is deliberately not implemented as this can cause additional table name conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants