Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VISIT_DETAIL in CDMv5.3.1 #279

Closed
ericaVoss opened this issue Nov 5, 2020 · 3 comments · Fixed by #286
Closed

VISIT_DETAIL in CDMv5.3.1 #279

ericaVoss opened this issue Nov 5, 2020 · 3 comments · Fixed by #286
Labels
bug Rabbit-In-A-Hat Issue concerning the specification of mapping rules

Comments

@ericaVoss
Copy link
Contributor

Is VISIT_DETAIL_ID missing from STEM in CDMv5.3.1?

Tagging @clairblacketer

@ericaVoss
Copy link
Contributor Author

Also, is MODIFIER_SOURCE_VALUE in there twice?

@MaximMoinat
Copy link
Collaborator

I think you found two bugs indeed. Should be simple to resolve in the following two csv files. And we should also check the other relevant cdm versions for these issues.

https://github.com/OHDSI/WhiteRabbit/blob/master/rabbitinahat/src/main/resources/org/ohdsi/rabbitInAHat/dataModel/StemTableV5.3.1.csv
https://github.com/OHDSI/WhiteRabbit/blob/master/rabbitinahat/src/main/resources/org/ohdsi/rabbitInAHat/dataModel/StemTableDefaultMappingV5.3.1.csv

@MaximMoinat MaximMoinat added bug Rabbit-In-A-Hat Issue concerning the specification of mapping rules labels Nov 5, 2020
@MaximMoinat
Copy link
Collaborator

@ericaVoss And feel free to open a PR 😄. Please use dev as target branch.

MaximMoinat pushed a commit that referenced this issue Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Rabbit-In-A-Hat Issue concerning the specification of mapping rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants