Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetPack 5.x rootfs slot A/B update #264

Closed
wants to merge 1 commit into from

Conversation

maciej-narojczyk
Copy link

Working PoC for AGX Orin. please comment

Only rootfs update, bootloader update is missing.
Happy path only, rollback is not working yet.



#mender
INHERIT += "mender-full"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is we'll need to use a dedicated tegrademo-mender.conf if we do it this way again, we won't want this to be a requirement in the base tegrademo.

Ideally it would be great to figure out how to keep this out of the distro conf and build mender support into a dedicated image instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwalkes I discussed it a bit internally, but we don't think there is a reasonably sane and maintainable way to move the logic into an image recipe. It might be technically possible, but would result in an image setup that is specific to OE4T and considerably more complex than "just" another distro, so it would be counterproductive.
What we can offer is to move the offending bits out of tegra-demo-distro into the Mender layers.

Copy link
Author

@maciej-narojczyk maciej-narojczyk Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I will try to think of something as well

.gitmodules Outdated
branch = kirkstone
[submodule "repos/meta-mender-community"]
path = repos/meta-mender-community
url = git@github.com:maciej-narojczyk/meta-mender-community.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need https URL here to get past the autobuilder.

@@ -0,0 +1,3 @@
export BB_ENV_PASSTHROUGH_ADDITIONS="MENDER_TENANT_TOKEN"
export MENDER_TENANT_TOKEN=`cat /data/codilime/mender/token`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to keep this file out of the base version?

Copy link
Contributor

@TheYoctoJester TheYoctoJester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first batch of comments from me. All in all we definitely need an organized way forwards for the distro part of things.

MENDER_UPDATE_POLL_INTERVAL_SECONDS = "15"
MENDER_SERVER_URL = "https://hosted.mender.io"
MENDER_DEVICE_TYPE:jetson-agx-orin-devkit = "jetson-agx-orin-devkit"
MENDER_ARTIFACT_SIGNING_KEY = "/data/codilime/mender/private.key"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed.

MENDER_SERVER_URL = "https://hosted.mender.io"
MENDER_DEVICE_TYPE:jetson-agx-orin-devkit = "jetson-agx-orin-devkit"
MENDER_ARTIFACT_SIGNING_KEY = "/data/codilime/mender/private.key"
MENDER_ARTIFACT_VERIFY_KEY = "/data/codilime/mender/public.key"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed.

IMAGE_FEATURES:append = " read-only-rootfs"


MENDER_INVENTORY_POLL_INTERVAL_SECONDS = "15"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the following intervals should be removed. See also comment on layers below.

@@ -18,4 +18,6 @@ BBLAYERS ?= " \
##OEROOT##/meta-tegra-support \
##OEROOT##/meta-demo-ci \
##OEROOT##/meta-tegrademo \
##OEROOT##/meta-mender-core \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to have a more reactive demo experience, meta-mender-demo should be added here instead of hardcoding intervals in the distro.



#mender
INHERIT += "mender-full"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwalkes I discussed it a bit internally, but we don't think there is a reasonably sane and maintainable way to move the logic into an image recipe. It might be technically possible, but would result in an image setup that is specific to OE4T and considerably more complex than "just" another distro, so it would be counterproductive.
What we can offer is to move the offending bits out of tegra-demo-distro into the Mender layers.

MENDER_RETRY_POLL_INTERVAL_SECONDS = "20"
MENDER_UPDATE_POLL_INTERVAL_SECONDS = "15"
MENDER_SERVER_URL = "https://hosted.mender.io"
MENDER_DEVICE_TYPE:jetson-agx-orin-devkit = "jetson-agx-orin-devkit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for that?

@dwalkes
Copy link
Member

dwalkes commented Aug 9, 2024

Closed, replaced by mendersoftware/meta-mender-community#394

@dwalkes dwalkes closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants