Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pip3 #986

Merged
merged 10 commits into from
Mar 15, 2023
Merged

upgrade pip3 #986

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5a03a3b
upgrade pip3
bertsky Feb 17, 2023
06e8a6c
stick to PIP variable throughout
bertsky Feb 17, 2023
7554fdc
reactivate Py36 test
bertsky Feb 17, 2023
4a37f35
seems to require sudo priv
bertsky Feb 17, 2023
3fb69f2
upgrade to bionic
bertsky Feb 17, 2023
385c595
make install: prefer binary OpenCV/Numpy on 3.6
bertsky Mar 14, 2023
46a53ab
CI: deps-test after install
bertsky Mar 14, 2023
276ab39
try new GH Action for GHCR Docker
bertsky Mar 14, 2023
bcd8d77
use PIP and PYTHON from environment, if any
bertsky Mar 15, 2023
8e9efaf
require importlib_resources for python <= 3.8, #996
kba Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ ENV DEBIAN_FRONTEND noninteractive
ENV PYTHONIOENCODING utf8
ENV LC_ALL=C.UTF-8
ENV LANG=C.UTF-8
ENV PIP=pip3

WORKDIR /build-ocrd
COPY ocrd ./ocrd
Expand All @@ -31,7 +32,7 @@ RUN apt-get update && apt-get -y install software-properties-common \
sudo \
git \
&& make deps-ubuntu \
&& pip install --upgrade pip setuptools \
&& pip3 install --upgrade pip setuptools \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try that already, that fixes this problem. But I stil fail locally to get opencv built.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading to a container which is based on Ubuntu > 18.04 would also have solved the problem because then python3-pip installs /usr/bin/pip, too.

&& make install \
&& apt-get remove -y gcc \
&& apt-get autoremove -y \
Expand Down