-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade pip3 #986
upgrade pip3 #986
Conversation
@@ -31,7 +32,7 @@ RUN apt-get update && apt-get -y install software-properties-common \ | |||
sudo \ | |||
git \ | |||
&& make deps-ubuntu \ | |||
&& pip install --upgrade pip setuptools \ | |||
&& pip3 install --upgrade pip setuptools \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did try that already, that fixes this problem. But I stil fail locally to get opencv built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading to a container which is based on Ubuntu > 18.04 would also have solved the problem because then python3-pip
installs /usr/bin/pip
, too.
Ok, it seems we got everything working here, except Scrutinizer, now failing for an outdated libgeos. Looks like the base image there is quite old. |
Wow! Just found out Scrutinizer still uses Trusty (Ubuntu 14)! I'll try upgrading to Bionic... |
@kba this resolves everything, at last! |
Not so sure about everything though: At least the Python 3.6 run looks suspiciously short. |
Note: … is necessary because when deps-test comes first, opencv-python-headless and numpy are already pulled, and so 385c595 would be too late … is a first shot at a GHCR deployment. I'm not sure whether it works. (One condition is that in the project Settings > Actions > General > Workflow Permissions, you have allowed read+write for GITHUB_TOKEN of this repo.) |
Excellent. Yes I'm testing the docker deployment - we also need to update the CUDA Ubuntu base image to 20.04, right? |
No we should already have that since f1527a2. The CI VM itself uses ubuntu-latest. |
https://github.com/OCR-D/core/pull/986/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R222 For |
Oh, right! |
Unfortunately, I cannot seem to get The old 18.04/3.6 image ( With
From running
and
I am not sure about the ramifications of updating libcudnn and not supporting CUDA 10 runtime here - @bertsky? |
Indeed, this will have grave implications for our TF 1.15 processors, probably also Detectron2. I recommend keeping core-cuda on the old (now defunct) image, tracking this in a new issue and merging here – we need the new release! |
ok, this sort of defies the original intent of this PR. But the fixes here are mostly for non-cuda now.... |
OK, let's release as-is and fix cuda later. |
attempts to fix the docker-cuda deploy failure.