[9.0] partner_firstname - Fix user form with firstname and lastname asking for a mandatory name #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvaucher
changed the title
|
It would be nice if you can add a test for this. |
| @@ -28,3 +28,10 @@ def default_get(self, fields_list): | |||
| result[field] = inverted.get(field) | |||
|
|
|||
| return result | |||
|
|
|||
| @api.one | |||
yvaucher
force-pushed
the
fix-firstname-user-form
branch
from
26e2b71 to
1a4ed83
Compare
|
Please check pylint error |
yvaucher
force-pushed
the
fix-firstname-user-form
branch
from
1a4ed83 to
5744cce
Compare
yvaucher
force-pushed
the
fix-firstname-user-form
branch
from
5744cce to
17d8619
Compare
|
@pedrobaeza fixed (don't over do, travis is already there to say so 😄 ) @yajo I just added a test on the onchange of user |
|
👍 @yvaucher, it was just in case you were not aware of it. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.