[9.0] [PORT] partner_firstname #238

yvaucher · 2016-01-13T12:14:34Z

Take history of module partner_firstname from 8.0
add missing authors
use reduced license header
move models in models directory
adapt views
show firstname, lastname only in edit mode
use company_type in views instead of is_company
adapt constraint on contacts
remove hack to make user editable
adapt check to accept invoicing or shipping address without name

yvaucher · 2016-01-13T14:19:13Z

pylint error is not related. I fix it in #239

pedrobaeza · 2016-01-18T11:25:33Z

Have you included latest changes in v8 following https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0?

yvaucher · 2016-01-18T12:17:40Z

@pedrobaeza Can you be more specific? What I did is use the new short license header, check the README.rst (some contributors were missing) and move files in models and views folder, as stated in the description of this PR. Plus changes to moke travis happy of course.

Got it you talk about commits in 8.0 tree. I'll check it

yvaucher · 2016-01-18T13:29:50Z

@pedrobaeza I added the missing commits some impact other modules. I tried to follow https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0 however, 2nd procedure had conflicts on cherry picks, thus I had to make cherry-picks one by one by hand.

pedrobaeza · 2016-01-18T13:36:52Z

I'm afraid cherry-picking doesn't work, because it modifies a lot of modules. Can you try again? Maybe I can bring the changes in 8.0 to 9.0 and then you rebase over that new 9.0 branch.

yvaucher · 2016-01-18T13:40:07Z

@pedrobaeza What I can do is reedit my cherry-pick to ignore change in other modules. But this will split the commits in 9.0. Especially for translation. Maybe I should drop completely the translation commits ?

pedrobaeza · 2016-01-18T13:49:35Z

You can use filter-branch in that commits to remove the rest of the modules, or directly discard then and then we need to make the translation again in Transifex. We can also do the other option I mention (prepare the 9.0 branch).

This fixes OCA#78 and adds new tests for it.

Conflicts: partner_firstname/__openerp__.py partner_firstname/tests/__init__.py

The real fix was in OCA#171. I leave the tests.

…tics. Conflicts: partner_contact_gender/__openerp__.py

antespi · 2016-01-20T09:51:26Z

partner_firstname/README.rst

+
+* Danish: Hans Henrik Gabelgaard
+* Italian: Leonardo Donelli
+* Spanish: Antonelli Espinosa


s/Antonelli Espinosa/Antonio Espinosa/

Sorry about that, I'll fix it.

- add missing authors - use reduced license header - move models in models directory - adapt views - show firstname, lastname only in edit mode - use company_type in views instead of is_company - adapt constraint on contacts

…iew. Fixed in odoo/odoo#cf63d4d277ef1ba02ff4ebcdae8583332a1775b1

yvaucher · 2016-01-20T12:10:19Z

@antespi It seems #227 is not ready yet. I can update this PR once it's resolved. Or we can do another PR.

antespi · 2016-01-20T13:45:07Z

@yvaucher ok, whatever first. Thanks

yajo · 2016-02-02T09:51:37Z

partner_firstname/tests/test_empty.py

+            "is_company": False,
+            "type": 'invoice',
+            "lastname": "",
+            "firstname": ""})


Is this really expected to work? A partner without name?

It does. For invoicing or shipping address only

Then shouldn't you add a test for shipping too?

JonathanNEMRY · 2016-02-11T15:18:37Z

Hello!
What's the status of this PR? Is the label need_review is always relevant?
In any cases, @yvaucher: Great work! I made some tests and it works perfectly. Also reviewed your code (maybe modification again about the name file res_partner.py) but for me it is a 👍

yvaucher · 2016-02-12T09:50:37Z

@pedrobaeza Fixed the user.py and partner.py filename
@yajo improved the comment about removing the constraint

@JonathanNEMRY Should be ready now

yajo · 2016-02-12T09:52:35Z

Would you mind fixing #238 (comment)?

yvaucher · 2016-02-12T09:58:03Z

@yajo this should do the trick 5dd2ceb

yajo · 2016-02-12T10:05:39Z

partner_firstname/tests/test_empty.py

+        """Create an shipping patner without name."""
+        self.original = self.env["res.partner"].create({
+            "is_company": False,
+            "type": 'shipping',


"delivery". See travis.

Indeed, thanks

yajo · 2016-02-12T11:14:00Z

👍 Tested on runbot. Great work!

JonathanNEMRY · 2016-02-12T11:23:04Z

Awesome! So it's ready to be merged 😄

[9.0] [PORT] partner_firstname

yvaucher · 2016-02-18T17:37:06Z

It seems we missed the required name on user form which forbid to create a user. Fixed here:

#249

pedrobaeza mentioned this pull request Jan 13, 2016

Migration to version 9.0 #184

Closed

31 tasks

yvaucher force-pushed the 9.0-port-partner-firstname branch 3 times, most recently from 59f95e0 to e4e2c3e Compare January 13, 2016 13:20

yvaucher added the needs review label Jan 13, 2016

yvaucher mentioned this pull request Jan 13, 2016

9.0 [MIG] port partner_firstname #232

Closed

yvaucher force-pushed the 9.0-port-partner-firstname branch from e4e2c3e to db36544 Compare January 13, 2016 13:48

yvaucher added this to the 9.0 milestone Jan 13, 2016

yvaucher force-pushed the 9.0-port-partner-firstname branch 2 times, most recently from 0e92966 to 4895b4e Compare January 14, 2016 11:07

yvaucher force-pushed the 9.0-port-partner-firstname branch from 4895b4e to 5f9b61b Compare January 18, 2016 13:29

Jairo Llopis added 9 commits January 18, 2016 14:58

Prepare partner_firstname for partner_second_lastname

353c84e

Fix OCA#78. Test it too.

eae6716

Inverse values of name if required at creation.

3b6ff05

Allow creation of partners from *Create and Edit*.

6b194f3

This fixes OCA#78 and adds new tests for it.

Fix bug OCA#154.

e7fe070

Conflicts: partner_firstname/__openerp__.py partner_firstname/tests/__init__.py

Fix flake8 error

2d8bf9b

After all, this was just a workaround. Remove it.

21c63b4

The real fix was in OCA#171. I leave the tests.

Fix test that was having sentences after return.

24f15fa

PEP8 fix.

df754ec

yvaucher force-pushed the 9.0-port-partner-firstname branch from 5f9b61b to ae0d15e Compare January 18, 2016 14:04

bealdav and others added 2 commits January 18, 2016 15:07

[FIX] _get_inverse_name in case of space in name

50498ce

Credit creators, using same name across modules to avoid split statis…

9477c44

…tics. Conflicts: partner_contact_gender/__openerp__.py

antespi reviewed Jan 20, 2016
View reviewed changes

yvaucher and others added 5 commits January 20, 2016 13:05

[PORT] partner_firstname to 9.0

efb51ad

- add missing authors - use reduced license header - move models in models directory - adapt views - show firstname, lastname only in edit mode - use company_type in views instead of is_company - adapt constraint on contacts

[PORT][9.0] partner_firstname - remove hack to be able to edit user v…

fb7d31d

…iew. Fixed in odoo/odoo#cf63d4d277ef1ba02ff4ebcdae8583332a1775b1

[PORT][9.0] partner_firstname - Format of string in __openerp__.py

1a5180e

[PORT][9.0] Adapt tests to take new constraint raising IntegrityError

05015ef

partner_firstname: Name is not mandatory if partner is an address

49e7175

yvaucher force-pushed the 9.0-port-partner-firstname branch from 3c43fdc to a55ea3e Compare January 20, 2016 12:05

yajo reviewed Feb 2, 2016
View reviewed changes

yvaucher added 3 commits February 12, 2016 10:49

fixup constraint

854d6a3

[FIX] Ensure default values are computed for res.users

d00ffec

Filename conventions

b5cabce

yvaucher force-pushed the 9.0-port-partner-firstname branch from 88ea07a to b5cabce Compare February 12, 2016 09:49

yajo reviewed Feb 12, 2016
View reviewed changes

Add test for shipping address with empty name

205ccfe

yvaucher force-pushed the 9.0-port-partner-firstname branch from 5dd2ceb to 205ccfe Compare February 12, 2016 10:10

pedrobaeza added a commit that referenced this pull request Feb 12, 2016

Merge pull request #238 from yvaucher/9.0-port-partner-firstname

3b65772

[9.0] [PORT] partner_firstname

pedrobaeza merged commit 3b65772 into OCA:9.0 Feb 12, 2016

yvaucher removed the needs review label Feb 12, 2016

yvaucher deleted the 9.0-port-partner-firstname branch February 15, 2016 09:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0] [PORT] partner_firstname #238

[9.0] [PORT] partner_firstname #238

yvaucher commented Jan 13, 2016

yvaucher commented Jan 13, 2016

pedrobaeza commented Jan 18, 2016

yvaucher commented Jan 18, 2016

yvaucher commented Jan 18, 2016

pedrobaeza commented Jan 18, 2016

yvaucher commented Jan 18, 2016

pedrobaeza commented Jan 18, 2016

antespi Jan 20, 2016

yvaucher Jan 20, 2016

yvaucher commented Jan 20, 2016

antespi commented Jan 20, 2016

yajo Feb 2, 2016

yvaucher Feb 2, 2016

yajo Feb 2, 2016

JonathanNEMRY commented Feb 11, 2016

yvaucher commented Feb 12, 2016

yajo commented Feb 12, 2016

yvaucher commented Feb 12, 2016

yajo Feb 12, 2016

yvaucher Feb 12, 2016

yajo commented Feb 12, 2016

JonathanNEMRY commented Feb 12, 2016

yvaucher commented Feb 18, 2016

[9.0] [PORT] partner_firstname #238

[9.0] [PORT] partner_firstname #238

Conversation

yvaucher commented Jan 13, 2016

yvaucher commented Jan 13, 2016

pedrobaeza commented Jan 18, 2016

yvaucher commented Jan 18, 2016

yvaucher commented Jan 18, 2016

pedrobaeza commented Jan 18, 2016

yvaucher commented Jan 18, 2016

pedrobaeza commented Jan 18, 2016

antespi Jan 20, 2016

Choose a reason for hiding this comment

yvaucher Jan 20, 2016

Choose a reason for hiding this comment

yvaucher commented Jan 20, 2016

antespi commented Jan 20, 2016

yajo Feb 2, 2016

Choose a reason for hiding this comment

yvaucher Feb 2, 2016

Choose a reason for hiding this comment

yajo Feb 2, 2016

Choose a reason for hiding this comment

JonathanNEMRY commented Feb 11, 2016

yvaucher commented Feb 12, 2016

yajo commented Feb 12, 2016

yvaucher commented Feb 12, 2016

yajo Feb 12, 2016

Choose a reason for hiding this comment

yvaucher Feb 12, 2016

Choose a reason for hiding this comment

yajo commented Feb 12, 2016

JonathanNEMRY commented Feb 12, 2016

yvaucher commented Feb 18, 2016