[MIG] crm_lead_firstname: Migration to 13.0 #305

ntsirintanis · 2020-02-05T15:09:50Z

No description provided.

rousseldenis · 2020-02-17T08:28:23Z

@ntsirintanis Could you try to rebase ?

NL66278 · 2020-02-25T07:24:55Z

@ntsirintanis Travis fails because of the precommit hook. Please black your code, preferably by using the pre-commit hook from the maintainer quality tools, before submitting again. Runbot fails due to running for more then an hour. This might be caused by other modules running very long to test. Unfortunately there is no detailed log available.

NL66278 · 2020-02-25T09:51:25Z

@ntsirintanis These are the fatal (ERROR) runbot errors:

�[91mERROR: pylint-odoo 0.0.1.dev459 has requirement lxml>=4.2.3, but you'll have lxml 3.7.1 which is incompatible.
�[0m�[91mERROR: coveralls 1.8.2 has requirement coverage<5.0,>=3.6, but you'll have coverage 5.0.3 which is incompatible.

hbrunn · 2020-02-25T09:53:43Z

I think https://travis-ci.org/OCA/crm/jobs/654812753#L849 is.

You need https://github.com/OCA/crm/blob/12.0/oca_dependencies.txt

NL66278 · 2020-02-25T09:54:23Z

@ntsirintanis and the oca-dependencies.txt file is missing. You can include this from the 12.0 branch as well. This contains the reference to the partner-contact repository.

ntsirintanis · 2020-02-25T10:12:56Z

OK, I'll see into correcting these failing unit tests

hbrunn · 2020-02-25T10:29:31Z

seems to me you'll have to migrate them to the new form stuff you were struggling with when trying to fix partner_firstname's tests. If you choose your tests wisely, you should be able to circumvent the bug triggered by partner_firstname, as the underlying issue is not yet fixed to my knowledge

crm_lead_firstname/tests/test_crm_lead.py

simahawk · 2020-03-17T07:27:46Z

hmm the commits sounds wrong: crm_lead_product is already in v13.
You should:

hard reset on 13.0
cherry-pick your migration commits
fix bugs

This module adds the lastname field to leads and converts current contact name into contact firstname. Allows to transfer that from and to res.partner objects.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-12.0/crm-12.0-crm_lead_firstname Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_firstname/

Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-crm_lead_firstname Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_firstname/de/

Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-crm_lead_firstname Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_firstname/hr/

Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-crm_lead_firstname Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_firstname/it/

ntsirintanis · 2020-03-17T10:49:22Z

@simahawk thanks a lot for your comments and review! I had mixed up some commits, but this is resolved now. Also fixed unit tests. Let's see if this gets green now.

ntsirintanis · 2020-03-17T12:59:08Z

@hbrunn @NL66278 @rousseldenis @simahawk LGTM please.

lfreeke

Functional test 👍

hbrunn

you can add yourself to the contributors

OCA-git-bot · 2020-03-18T06:58:31Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

simahawk

LG, just a bunch of small changes please :)

crm_lead_firstname/tests/test_crm_lead.py

crm_lead_firstname/__manifest__.py

crm_lead_firstname/readme/INSTALL.rst

ntsirintanis · 2020-03-18T11:21:24Z

@simahawk please take another look.

…changes

simahawk · 2020-03-18T13:00:08Z

/ocabot merge

OCA-git-bot · 2020-03-18T13:00:45Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-305-by-simahawk-bump-no, awaiting test results.

OCA-git-bot · 2020-03-18T13:37:15Z

Congratulations, your PR was merged at 08184ac. Thanks a lot for contributing to OCA. ❤️

rousseldenis added this to the 13.0 milestone Feb 17, 2020

rousseldenis added migration needs review labels Feb 17, 2020

ntsirintanis force-pushed the 13.0-mig-crm_lead_firstname branch from 4a6f385 to 4ac2635 Compare February 17, 2020 09:14

ntsirintanis force-pushed the 13.0-mig-crm_lead_firstname branch from 4ac2635 to a8e0b61 Compare February 24, 2020 14:09

ntsirintanis force-pushed the 13.0-mig-crm_lead_firstname branch from dc75754 to 660e834 Compare February 26, 2020 10:24

lfreeke mentioned this pull request Mar 9, 2020

[13.0][MIG] crm_lead_firstname #308

Closed

simahawk reviewed Mar 17, 2020

View reviewed changes

crm_lead_firstname/tests/test_crm_lead.py Outdated Show resolved Hide resolved

simahawk added needs fixing and removed needs review labels Mar 17, 2020

simahawk changed the title ~~13.0 mig crm lead firstname~~ [MIG] crm_lead_firstname: Migration to 13.0 Mar 17, 2020

ntsirintanis force-pushed the 13.0-mig-crm_lead_firstname branch 2 times, most recently from e15d5ba to 12ef0e8 Compare March 17, 2020 10:04

yajo and others added 9 commits March 17, 2020 11:17

[8.0][crm_lead_firstname] Link crm and partner_firstname modules.

73c487f

This module adds the lastname field to leads and converts current contact name into contact firstname. Allows to transfer that from and to res.partner objects.

OCA Transbot updated translations from Transifex

3e3a0e3

[MIG] crm_lead_firstname: Migration to 11.0

92bab98

[UPD] Update crm_lead_firstname.pot

da21868

[MIG] crm_lead_firstname: Migration to 12.0

ce2a8b2

[UPD] Update crm_lead_firstname.pot

51d8043

Update translation files

143a449

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-12.0/crm-12.0-crm_lead_firstname Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_firstname/

Translated using Weblate (German)

3f737ca

Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-crm_lead_firstname Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_firstname/de/

[UPD] README.rst

80c4582

badbole and others added 4 commits March 17, 2020 11:17

Translated using Weblate (Croatian)

4901c0c

Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-crm_lead_firstname Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_firstname/hr/

Translated using Weblate (Italian)

ad52cff

Currently translated at 100.0% (6 of 6 strings) Translation: crm-12.0/crm-12.0-crm_lead_firstname Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_firstname/it/

[MIG] crm_lead_firstname: Migration to 13.0

b44b658

[IMP] crm_lead_firstname: black, isort

10c1a06

ntsirintanis force-pushed the 13.0-mig-crm_lead_firstname branch from 12ef0e8 to 10c1a06 Compare March 17, 2020 10:21

ntsirintanis force-pushed the 13.0-mig-crm_lead_firstname branch 2 times, most recently from f694481 to 9ba1e7d Compare March 17, 2020 12:14

lfreeke approved these changes Mar 17, 2020

View reviewed changes

hbrunn approved these changes Mar 18, 2020

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 18, 2020

simahawk requested changes Mar 18, 2020

View reviewed changes

crm_lead_firstname/tests/test_crm_lead.py Show resolved Hide resolved

crm_lead_firstname/__manifest__.py Outdated Show resolved Hide resolved

crm_lead_firstname/__manifest__.py Outdated Show resolved Hide resolved

crm_lead_firstname/readme/INSTALL.rst Outdated Show resolved Hide resolved

OCA-git-bot removed approved ready to merge labels Mar 18, 2020

ntsirintanis force-pushed the 13.0-mig-crm_lead_firstname branch from 9ba1e7d to a502563 Compare March 18, 2020 09:31

[FIX] unit tests in crm_lead_firstname, linting errors, minor review …

33e6383

…changes

ntsirintanis force-pushed the 13.0-mig-crm_lead_firstname branch from a502563 to 33e6383 Compare March 18, 2020 11:35

simahawk approved these changes Mar 18, 2020

View reviewed changes

OCA-git-bot added the approved label Mar 18, 2020

simahawk removed the needs fixing label Mar 18, 2020

OCA-git-bot merged commit 2253bec into OCA:13.0 Mar 18, 2020

OCA-git-bot added the merged 🎉 label Mar 18, 2020

tonygalmiche mentioned this pull request May 28, 2020

Migration to version 13.0 #295

Closed

17 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] crm_lead_firstname: Migration to 13.0 #305

[MIG] crm_lead_firstname: Migration to 13.0 #305

ntsirintanis commented Feb 5, 2020

rousseldenis commented Feb 17, 2020

NL66278 commented Feb 25, 2020

NL66278 commented Feb 25, 2020

hbrunn commented Feb 25, 2020

NL66278 commented Feb 25, 2020

ntsirintanis commented Feb 25, 2020

hbrunn commented Feb 25, 2020

simahawk commented Mar 17, 2020

ntsirintanis commented Mar 17, 2020

ntsirintanis commented Mar 17, 2020

lfreeke left a comment

hbrunn left a comment

OCA-git-bot commented Mar 18, 2020

simahawk left a comment

ntsirintanis commented Mar 18, 2020

simahawk commented Mar 18, 2020

OCA-git-bot commented Mar 18, 2020

OCA-git-bot commented Mar 18, 2020

[MIG] crm_lead_firstname: Migration to 13.0 #305

[MIG] crm_lead_firstname: Migration to 13.0 #305

Conversation

ntsirintanis commented Feb 5, 2020

rousseldenis commented Feb 17, 2020

NL66278 commented Feb 25, 2020

NL66278 commented Feb 25, 2020

hbrunn commented Feb 25, 2020

NL66278 commented Feb 25, 2020

ntsirintanis commented Feb 25, 2020

hbrunn commented Feb 25, 2020

simahawk commented Mar 17, 2020

ntsirintanis commented Mar 17, 2020

ntsirintanis commented Mar 17, 2020

lfreeke left a comment

Choose a reason for hiding this comment

hbrunn left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Mar 18, 2020

simahawk left a comment

Choose a reason for hiding this comment

ntsirintanis commented Mar 18, 2020

simahawk commented Mar 18, 2020

OCA-git-bot commented Mar 18, 2020

OCA-git-bot commented Mar 18, 2020