[FIX] unit tests in crm_lead_firstname, linting errors, minor review changes

Author: ntsirintanis

crm_lead_firstname/__manifest__.py

@@ -1,15 +1,15 @@
-# © 2016 Antiun Ingeniería S.L. - Jairo Llopis
+# Copyright 2016 Antiun Ingeniería S.L. - Jairo Llopis
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 {
     "name": "Firstname and Lastname in Leads",
     "summary": "Specify split names for contacts in leads",
     "version": "13.0.1.0.0",
     "category": "Customer Relationship Management",
-    "website": "http://www.github.com/OCA/crm",
+    "website": "http://github.com/OCA/crm",
     "author": "Tecnativa, Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "application": False,
     "installable": True,
-    "depends": ["crm", "partner_firstname",],
-    "data": ["views/crm_lead_view.xml",],
+    "depends": ["crm", "partner_firstname"],
+    "data": ["views/crm_lead_view.xml"],
 }

crm_lead_firstname/models/crm_lead.py

@@ -1,4 +1,4 @@
-# © 2016 Antiun Ingeniería S.L. - Jairo Llopis
+# Copyright 2016 Antiun Ingeniería S.L. - Jairo Llopis
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 from odoo import fields, models
@@ -17,15 +17,11 @@ def _create_lead_partner_data(self, name, is_company, parent_id=False):
         )
         if not is_company:
             if self.contact_name:
-                lead_partner_data.update(
-                    {"firstname": self.contact_name,}
-                )
+                lead_partner_data.update({"firstname": self.contact_name})
                 if "name" in lead_partner_data:
                     del lead_partner_data["name"]
             if self.contact_lastname:
-                lead_partner_data.update(
-                    {"lastname": self.contact_lastname,}
-                )
+                lead_partner_data.update({"lastname": self.contact_lastname})
                 if "name" in lead_partner_data:
                     del lead_partner_data["name"]
         return lead_partner_data

crm_lead_firstname/readme/CONTRIBUTORS.rst

@@ -1,3 +1,4 @@
 * Rafael Blasco
 * Jairo Llopis
 * Raf Ven <raf.ven@dynapps.be>
+* Nikos Tsirintanis <ntsirintanis@therp.nl>

crm_lead_firstname/readme/DESCRIPTION.rst

@@ -1,3 +1,7 @@
 This module extends the functionality of CRM leads to support split first and
 last name fields for contacts and allow you to port that information to and
 from partners.
+Since leads are expected to create partners only when needed and after
+information is correctly set up, in leads there is no inverse logic to
+transform the old single name in the new split names automatically. The old
+single name will simply be the firstname now.

crm_lead_firstname/readme/INSTALL.rst

@@ -1,8 +1,3 @@
-Since leads are expected to create partners only when needed and after
-information is correctly set up, in leads there is no inverse logic to
-transform the old single name in the new split names automatically. The old
-single name will simply be the firstname now.
-
 To install this module, you need to:
 
 * Install `OCA/partner-contact <https://github.com/OCA/partner-contact>`_ repo.

crm_lead_firstname/tests/test_crm_lead.py

@@ -1,13 +1,14 @@
-# © 2016 Antiun Ingeniería S.L. - Jairo Llopis
+# Copyright 2016 Antiun Ingeniería S.L. - Jairo Llopis
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from odoo.tests.common import SavepointCase
+from odoo.tests.common import Form, SavepointCase
 
 
 class FirstNameCase(SavepointCase):
     @classmethod
     def setUpClass(cls):
         super(FirstNameCase, cls).setUpClass()
+        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
         cls.lead_model = cls.env["crm.lead"]
         cls.partner_model = cls.env["res.partner"]
         cls.lead = cls.lead_model.create(
@@ -19,7 +20,7 @@ def setUpClass(cls):
             }
         )
         cls.partner = cls.partner_model.create(
-            {"firstname": "Firçt name", "lastname": "Laçt name",}
+            {"firstname": "Firçt name", "lastname": "Laçt name"}
         )
 
     def test_create_contact(self):
@@ -31,15 +32,14 @@ def test_create_contact(self):
 
     def test_create_contact_empty(self):
         """No problems creating a contact without names."""
-        self.lead.write(
-            {"contact_name": False, "contact_lastname": False,}
-        )
+        self.lead.write({"contact_name": False, "contact_lastname": False})
         self.lead.handle_partner_assignation()
 
     def test_onchange_partner(self):
         """When changing partner, fields get correctly updated."""
-        with self.env.do_in_onchange():
-            self.lead.partner_id = self.partner
-            value = self.lead._onchange_partner_id_values(self.partner.id)
-            self.assertEqual(self.partner.firstname, value["contact_name"])
-            self.assertEqual(self.partner.lastname, value["contact_lastname"])
+        with Form(self.env["crm.lead"], view="crm.crm_lead_view_form") as lead_form:
+            lead_form.partner_id = self.partner
+            lead_form.name = self.partner.name
+            lead_form.save()
+            self.assertEqual(self.partner.firstname, lead_form.contact_name)
+            self.assertEqual(self.partner.lastname, lead_form.contact_lastname)

crm_lead_firstname/views/crm_lead_view.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8" ?>
-<!-- © 2016 Antiun Ingeniería S.L. - Jairo Llopis
+<!-- Copyright 2016 Antiun Ingeniería S.L. - Jairo Llopis
      License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). -->
 <odoo>
     <record id="crm_lead_view_form" model="ir.ui.view">

setup/crm_lead_firstname/odoo/addons/crm_lead_firstname

@@ -0,0 +1 @@
+../../../../crm_lead_firstname

setup/crm_lead_firstname/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)