Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow #275

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{

"env": {
"browser": true,
"es2021": true,
"global": true
},
"extends": "eslint:recommended",
"overrides": [
{
"files": ["**/*.test.js"],
"env": { "jest": true },
"plugins": ["jest"],
"extends": ["plugin:jest/recommended"],
"rules": { "jest/prefer-expect-assertions": "off" }
},
{
"files": ["**/*.cy.js"],
"env": { "cypress/globals": true },
"plugins": ["cypress"],
"extends": ["plugin:cypress/recommended"],
"rules": {
"cypress/no-unnecessary-waiting": "off",
"no-unused-vars": "off"
}
}

],
"parserOptions": {
"ecmaVersion": "latest",
"sourceType": "module"
},
"rules": {
}
}
12 changes: 12 additions & 0 deletions 6
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

added 52 packages, and audited 371 packages in 3s

54 packages are looking for funding
run `npm fund` for details

3 high severity vulnerabilities

To address all issues, run:
npm audit fix

Run `npm audit` for details.
Comment on lines +1 to +12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

The changes indicate that there are 3 high severity vulnerabilities in your dependencies. It's recommended to address these issues as soon as possible to maintain the security of your application. You can do this by running npm audit fix. If automatic fixing is not possible, you may need to manually update or replace the affected packages.

+   npm audit fix

Also, consider setting up a process to regularly check for and resolve vulnerabilities in your dependencies. This could be a scheduled job that runs npm audit and alerts you if any vulnerabilities are found.

Comment on lines +1 to +12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

The changes indicate that there are 3 high severity vulnerabilities in your dependencies. It's recommended to address these issues as soon as possible to maintain the security of your application. You can do this by running npm audit fix. If automatic fixing is not possible, you may need to manually update or replace the affected packages.

+   npm audit fix

Also, consider setting up a process to regularly check for and resolve vulnerabilities in your dependencies. This could be a scheduled job that runs npm audit and alerts you if any vulnerabilities are found.

1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
When i ran a test on the login i got a failed test in wich said that localstorage was empty.
3 changes: 3 additions & 0 deletions babel.config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"presets": [["@babel/preset-env", { "targets": { "node": "current" } }]]
}
1 change: 1 addition & 0 deletions cypress.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
7 changes: 5 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import router from "./router/index.js";
import ui from "./ui/index.js";

ui()
router()
ui();
router();
Comment on lines +5 to +6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

The indentation of the router() function call is inconsistent with the rest of the code. It's best to maintain consistent indentation for readability and maintainability.

-    router();
+router();

Comment on lines +5 to +6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

The indentation of the router() function call is inconsistent with the rest of the code. It's best to maintain consistent indentation for readability and maintainability.

-    router();
+router();


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

There should be a newline at the end of the file. This is a common convention that makes it easier to concatenate files and work with them on the command line. Some tools might not work correctly with files that don't end with a newline.

- \ No newline at end of file
+ 
- \ No newline at end of file
+ 

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

There should be a newline at the end of the file. This is a common convention that makes it easier to concatenate files and work with them on the command line. Some tools might not work correctly with files that don't end with a newline.

- \ No newline at end of file
+ 
- \ No newline at end of file
+ 

// h
console.log(dogcat)
Loading
Loading