Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rt: update dependency list #82823

Closed
wants to merge 1 commit into from
Closed

rt: update dependency list #82823

wants to merge 1 commit into from

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Mar 18, 2020 •
edited
Loading

Motivation for this change

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska KamilaBorowska mentioned this pull request Mar 18, 2020
Closed
10 tasks
mmilata
mmilata approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds! License is correct. I was wondering why this builds without Crypt::SSLeay and that dependecy was removed in upstream in previous version: bestpractical/rt@c567d14

Result of nixpkgs-review pr 82823 1

1 package built:
  • rt

@KamilaBorowska
Copy link
Member Author

I think #80677 makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KamilaBorowska @mmilata