Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rt: fix build error #80677

Merged
merged 1 commit into from
Mar 20, 2020
Merged

rt: fix build error #80677

merged 1 commit into from
Mar 20, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Feb 20, 2020

ZHF: #80379
https://hydra.nixos.org/build/113061284

Added requiredPerlModules as suggested for similar problem as described for
similar problem here:
#72783 (comment)

Things done

Tested that rt starts by following instructions in pkgs/servers/rt/default.nix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
rt: fix build error
7f6a3cd 
ZHF: NixOS#80379
https://hydra.nixos.org/build/113061284

Added requiredPerlModules as suggested for similar problem as described for
similar problem here:
NixOS#72783 (comment)
jonringer
jonringer approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not familiar with perl

[3 built, 94 copied (26.7 MiB), 11.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80677
1 package built:
rt

This was referenced Feb 24, 2020
Merged
Merged
@vcunat
Copy link
Member

vcunat commented Mar 2, 2020

I'd say this depends on #81438.

@KamilaBorowska KamilaBorowska mentioned this pull request Mar 19, 2020
Closed
10 tasks
@jonringer
Copy link
Contributor

again,

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80677
1 package built:
rt

@jonringer jonringer merged commit 3e50e26 into NixOS:master Mar 20, 2020
@mmilata mmilata mentioned this pull request Mar 28, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilaBorowska KamilaBorowska KamilaBorowska approved these changes

@jonringer jonringer jonringer approved these changes

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stigtsp @vcunat @jonringer @KamilaBorowska