-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libgcrypt: fix bad locking behavior introduced in update #42150
Conversation
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
Looks like yes hangs w/o the patch--time to reconfirm with patch once timeout triggers! Well, force-pushing it now hopefully the timeout result isn't too confusing when it completes :). |
f5fe6a9
to
bb90cbf
Compare
Failure on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
Woohoo! 😁 Sent email to upstream mailing list, pending moderator approval I think. |
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
I suppose this should go to staging first due to mass-rebuilds... |
...But that's messy because staging doesn't have the commit from master/18.03 that disables tests that this fixes. Blargh. |
@dtzWill let's merge master into staging first then. |
Yes please! |
Targeting staging now, think this is good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if ofborg agrees.
@GrahamcOfBorg build libgcrypt |
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: libgcrypt Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: libgcrypt Partial log (click to expand)
|
As-is this hangs on musl (and possibly cause of Darwin hangs)
due to trying to obtain non-recursive lock already held.
Especially if this seems to fix hanging problems on Darwin,
will be reporting upstream.
Probably should wait until that happens or this is
otherwise investigated further.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)