Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgcrypt: disable tests w/musl, seems to hang #42146

Closed
wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 17, 2018

Maybe same problem as on Darwin, unsure.

From gdb:

Thread 1 (process 23820):
#0 0x00007ffff7dab684 in __syscall_cp_c () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1
#1 0x00007ffff7daac69 in __timedwait_cp () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1
#2 0x00007ffff7daad17 in __timedwait () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1
#3 0x00007ffff7dacaf4 in pthread_mutex_timedlock () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1
#4 0x00007ffff781e409 in _gpgrt_lock_lock () from target:/nix/store/f7qid95jabfr665qc1kbcl6adf48gq7w-libgpg-error-1.28/lib/libgpg-error.so.0
#5 0x00007ffff7b035d5 in lock_rng () at ./rndjent.c:212
#6 0x00007ffff7b036ab in _gcry_rndjent_poll (add=0x0, origin=RANDOM_ORIGIN_INIT, length=0) at ./rndjent.c:268
#7 0x00007ffff7b038cf in _gcry_rndjent_get_version (r_active=0x7fffffffc800) at ./rndjent.c:339
#8 0x00007ffff7a44f7f in print_config (fp=0x6026e0, what=0x0) at global.c:391
#9 _gcry_get_config (mode=mode@entry=0, what=, what@entry=0x0) at global.c:420
#10 0x00007ffff7a456a3 in _gcry_vcontrol (cmd=, arg_ptr=) at global.c:652
#11 0x00007ffff7a41689 in gcry_control (cmd=cmd@entry=GCRYCTL_PRINT_CONFIG) at visibility.c:79
#12 0x0000000000400ec3 in main (argc=, argv=) at version.c:160

Planning to cherry-pick this onto 18.03 as well
(like was done for the Darwin fix).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Maybe same problem as on Darwin, unsure.

From gdb:

> Thread 1 (process 23820):
> #0  0x00007ffff7dab684 in __syscall_cp_c () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1
> #1  0x00007ffff7daac69 in __timedwait_cp () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1
> #2  0x00007ffff7daad17 in __timedwait () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1
> #3  0x00007ffff7dacaf4 in pthread_mutex_timedlock () from target:/nix/store/66m5z7marjbs7pa3gv8sf5j1qrqjacfj-musl-1.1.19/lib/ld-musl-x86_64.so.1
> NixOS#4  0x00007ffff781e409 in _gpgrt_lock_lock () from target:/nix/store/f7qid95jabfr665qc1kbcl6adf48gq7w-libgpg-error-1.28/lib/libgpg-error.so.0
> NixOS#5  0x00007ffff7b035d5 in lock_rng () at ./rndjent.c:212
> NixOS#6  0x00007ffff7b036ab in _gcry_rndjent_poll (add=0x0, origin=RANDOM_ORIGIN_INIT, length=0) at ./rndjent.c:268
> NixOS#7  0x00007ffff7b038cf in _gcry_rndjent_get_version (r_active=0x7fffffffc800) at ./rndjent.c:339
> NixOS#8  0x00007ffff7a44f7f in print_config (fp=0x6026e0, what=0x0) at global.c:391
> NixOS#9  _gcry_get_config (mode=mode@entry=0, what=<optimized out>, what@entry=0x0) at global.c:420
> NixOS#10 0x00007ffff7a456a3 in _gcry_vcontrol (cmd=<optimized out>, arg_ptr=<optimized out>) at global.c:652
> NixOS#11 0x00007ffff7a41689 in gcry_control (cmd=cmd@entry=GCRYCTL_PRINT_CONFIG) at visibility.c:79
> NixOS#12 0x0000000000400ec3 in main (argc=<optimized out>, argv=<optimized out>) at version.c:160
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libgcrypt

Partial log (click to expand)

/nix/store/q9j7ky21scd3lxxjj5yr5n3jpsyd2bj7-libgcrypt-1.8.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libgcrypt

Partial log (click to expand)

/nix/store/150r1ggzh95354vpdrl0b896hd5hwv7b-libgcrypt-1.8.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libgcrypt

Partial log (click to expand)

these paths will be fetched (0.45 MiB download, 1.44 MiB unpacked):
  /nix/store/15djki9fy45azrpnf3cxyy2jmrjymr7p-libgcrypt-1.8.3
  /nix/store/jfrrwb33bs6il3xdm79w8jl2frqnnl8z-libgpg-error-1.28
copying path '/nix/store/jfrrwb33bs6il3xdm79w8jl2frqnnl8z-libgpg-error-1.28' from 'https://cache.nixos.org'...
copying path '/nix/store/15djki9fy45azrpnf3cxyy2jmrjymr7p-libgcrypt-1.8.3' from 'https://cache.nixos.org'...
/nix/store/15djki9fy45azrpnf3cxyy2jmrjymr7p-libgcrypt-1.8.3

@dtzWill
Copy link
Member Author

dtzWill commented Jun 18, 2018

Oh, nevermind they seem to be trying to obtain a lock they already have, but aren't using a recursive lock?

Will investigate...

@dtzWill
Copy link
Member Author

dtzWill commented Jun 18, 2018

Exploring locking badness fix in #42150 which replaces this if patch looks good. Closing for now.

(EDIT: oops wrong PR number)

@dtzWill dtzWill closed this Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants