-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svt-av1: 2.1.2 -> 2.2.0 #336564
svt-av1: 2.1.2 -> 2.2.0 #336564
Conversation
Note that PGO is in conflict with reproducibility, and this package is in the closure of several critical packages like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend droping the second commit as it currently breaks reproducibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the pr, the changes now look good to me, and I tested that they work by encoding a video in FFmpeg with it and playing the resulting video.
Just one issue, that I overlooked in my previous review is that this should be targeting staging, could you please rebase the changes onto it, while follow the instructions from https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging carefully.
Thanks!
Thanks @jopejoe1 ! I have switched target to staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description of changes
As a follow-up of #228556, this PR enables some additional optimization flags:
-DSVT_AV1_PGO=ON
: Enables profile-guided optimization, according to official build instructions: "(LTO and PGO can be combined, for maximum gains)". See build.sh.-DCMAKE_BUILD_TYPE=Release
,-DNATIVE=ON
are also from the source that #228556 referenced.Enabling PGO only works with 2.2.0, so this PR also bumps version from 2.1.2 to 2.2.0, see release notes.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.