Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svt-av1: 2.1.2 -> 2.2.0 #336564

Merged
merged 1 commit into from
Aug 24, 2024
Merged

svt-av1: 2.1.2 -> 2.2.0 #336564

merged 1 commit into from
Aug 24, 2024

Conversation

hexacera
Copy link
Contributor

@hexacera hexacera commented Aug 22, 2024

Description of changes

As a follow-up of #228556, this PR enables some additional optimization flags:

Enabling PGO only works with 2.2.0, so this PR also bumps version from 2.1.2 to 2.2.0, see release notes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 22, 2024
@emilazy
Copy link
Member

emilazy commented Aug 22, 2024

Note that PGO is in conflict with reproducibility, and this package is in the closure of several critical packages like ffmpeg, so this would most likely compromise the reproducibility of the installer ISOs.

Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend droping the second commit as it currently breaks reproducibility.

pkgs/tools/video/svt-av1/default.nix Outdated Show resolved Hide resolved
pkgs/tools/video/svt-av1/default.nix Outdated Show resolved Hide resolved
@hexacera hexacera changed the title svt-av1: 2.1.2 -> 2.2.0 and enable profile-guided optimization svt-av1: 2.1.2 -> 2.2.0 Aug 23, 2024
@hexacera
Copy link
Contributor Author

Thanks @emilazy and @jopejoe1! I see that's why these flags aren't enabled already. I have dropped the second commit and updated the PR title such that this PR is a version bump only.

@hexacera hexacera requested a review from jopejoe1 August 23, 2024 05:39
Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the pr, the changes now look good to me, and I tested that they work by encoding a video in FFmpeg with it and playing the resulting video.

Just one issue, that I overlooked in my previous review is that this should be targeting staging, could you please rebase the changes onto it, while follow the instructions from https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging carefully.
Thanks!

@hexacera hexacera changed the base branch from master to staging August 24, 2024 04:28
@hexacera
Copy link
Contributor Author

Thanks @jopejoe1 ! I have switched target to staging.

Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jopejoe1 jopejoe1 merged commit 379cbc4 into NixOS:staging Aug 24, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants