Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svt-av1: enable link-time-optimization #228556

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

MatthewCroughan
Copy link
Contributor

Description of changes

Enable link-time-optimization to improve performance, gathered from https://www.reddit.com/r/AV1/comments/z9fo51/svtav1_on_arm/

I'm wondering if we should also experiment with -DBUILD_SHARED_LIBS=OFF.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member

wegank commented Sep 10, 2023

@ofborg build svt-av1 svt-av1.passthru.tests

@wegank
Copy link
Member

wegank commented Sep 11, 2023

Result of nixpkgs-review pr 228556 run on aarch64-darwin 1

1 package failed to build:
  • handbrake
1 package built:
  • svt-av1

@wegank
Copy link
Member

wegank commented Sep 11, 2023

Result of nixpkgs-review pr 228556 run on x86_64-darwin 1

19 packages marked as broken and skipped:
  • arcanPackages.arcan
  • arcanPackages.xarcan
  • handbrake
  • liquidsoap
  • manim
  • manim.dist
  • python310Packages.moderngl-window
  • python310Packages.moderngl-window.dist
  • python310Packages.pyglet
  • python310Packages.pyglet.dist
  • python310Packages.pytmx
  • python310Packages.pytmx.dist
  • python311Packages.moderngl-window
  • python311Packages.moderngl-window.dist
  • python311Packages.pyglet
  • python311Packages.pyglet.dist
  • python311Packages.pytmx
  • python311Packages.pytmx.dist
  • rofi-screenshot
4 packages failed to build:
  • python310Packages.gradio
  • python310Packages.gradio.dist
  • python311Packages.gradio
  • python311Packages.gradio.dist
46 packages built:
  • MIDIVisualizer
  • ffmpeg-full (arcanPackages.ffmpeg ,ffmpeg_5-full)
  • ffmpeg-full.bin (arcanPackages.ffmpeg.bin ,ffmpeg_5-full.bin)
  • ffmpeg-full.data (arcanPackages.ffmpeg.data ,ffmpeg_5-full.data)
  • ffmpeg-full.dev (arcanPackages.ffmpeg.dev ,ffmpeg_5-full.dev)
  • ffmpeg-full.doc (arcanPackages.ffmpeg.doc ,ffmpeg_5-full.doc)
  • ffmpeg-full.lib (arcanPackages.ffmpeg.lib ,ffmpeg_5-full.lib)
  • ffmpeg-full.man (arcanPackages.ffmpeg.man ,ffmpeg_5-full.man)
  • corrscope
  • corrscope.dist
  • ffmpeg_4-full
  • ffmpeg_4-full.bin
  • ffmpeg_4-full.data
  • ffmpeg_4-full.dev
  • ffmpeg_4-full.doc
  • ffmpeg_4-full.lib
  • ffmpeg_4-full.man
  • ffmpeg_6-full
  • ffmpeg_6-full.bin
  • ffmpeg_6-full.data
  • ffmpeg_6-full.dev
  • ffmpeg_6-full.doc
  • ffmpeg_6-full.lib
  • ffmpeg_6-full.man
  • jellyfin
  • python310Packages.aigpy
  • python310Packages.aigpy.dist
  • python310Packages.gradio-client
  • python310Packages.gradio-client.dist
  • python310Packages.pydub
  • python310Packages.pydub.dist
  • python310Packages.shazamio
  • python310Packages.shazamio.dist
  • python311Packages.aigpy
  • python311Packages.aigpy.dist
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.pydub
  • python311Packages.pydub.dist
  • python311Packages.shazamio
  • python311Packages.shazamio.dist
  • shaq
  • shaq.dist
  • svt-av1
  • tidal-dl
  • tidal-dl.dist

@wegank wegank merged commit 61770df into NixOS:master Sep 11, 2023
@MatthewCroughan MatthewCroughan deleted the mc/svt-av1-lto branch September 11, 2023 17:47
@hexacera hexacera mentioned this pull request Aug 22, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants