[staging-next] PHP 8.2 and 8.3 fixes for libxml2 2.13 #330299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reckenrode
requested review from
jtojnar,
aanderse,
drupol,
globin,
Ma27 and
talyz
as code owners
|
I can drop soap, xml, and xmlwriter if that would be preferred since they do seem to build on Hydra. |
|
Result of 1 package marked as broken and skipped:
22 packages failed to build:
108 packages built:
|
vcunat
requested changes
Jul 27, 2024
There was a problem hiding this comment.
The soap part is still failing on *-linux (ofBorg and locally).
> FAILED TEST SUMMARY
> ---------------------------------------------------------------------
> SOAP Bug #71610 - Type Confusion Vulnerability - SOAP / make_http_soap_request() [tests/bug71610.phpt]
> Bug #76348 (WSDL_CACHE_MEMORY causes Segmentation fault) [tests/bugs/bug76348.phpt]
On *-linux we get: > FAILED TEST SUMMARY > --------------------------------------------------------------------- > SOAP Bug NixOS#71610 - Type Confusion Vulnerability - SOAP / make_http_soap_request() [tests/bug71610.phpt] > Bug NixOS#76348 (WSDL_CACHE_MEMORY causes Segmentation fault) [tests/bugs/bug76348.phpt] Logs e.g.: https://github.com/NixOS/nixpkgs/pull/330299/checks?check_run_id=27989364591
|
Oh, you enabled tests on the soap part. They pass on aarch64-darwin for me, but clearly not on *-linux, so let me simply disable them on Linux again. |
I assumed it was a libxml2 issue not some other issue. Thanks for catching that and fixing it. |
|
I wouldn't say I "fixed" it, but seems good enough to merge, even though PHP 8.1 looks broken. |
drupol
added
backport release-24.05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Applies upstream patches to fix libxml2 2.13 compatibility issues. Fixes build failures on staging-next #328673.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.