Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: php-simplexml-8.1.2 #331126

Closed
olafkfreund opened this issue Jul 30, 2024 · 6 comments · Fixed by #334411
Closed

Build failure: php-simplexml-8.1.2 #331126

olafkfreund opened this issue Jul 30, 2024 · 6 comments · Fixed by #334411

Comments

@olafkfreund
Copy link

Steps To Reproduce

Steps to reproduce the behavior:

  1. build php-simplexml-8.1.2

Build log

> PASS SimpleXML: invoking key() after the iterator has already been consumed [tests/key_error.phpt]
┃        > SKIP GHSA-3qrf-m4j2-pcrr (libxml global state entity loader bypass) [tests/libxml_global_state_entity_loader_bypass.phpt] reason: zend-test extension not available
┃        > PASS SimpleXML [profile]: Accessing a simple node [tests/profile01.phpt]
┃        > PASS SimpleXML [profile]: Accessing an array of subnodes [tests/profile02.phpt]
┃        > PASS SimpleXML [profile]: Accessing an attribute [tests/profile03.phpt]
┃        > PASS SimpleXML [profile]: Accessing a namespaced element [tests/profile04.phpt]
┃        > PASS SimpleXML [profile]: Accessing an aliased namespaced element [tests/profile05.phpt]
┃        > PASS SimpleXML [profile]: Accessing a namespaced attribute [tests/profile06.phpt]
┃        > PASS SimpleXML [profile]: Accessing an aliased namespaced attribute [tests/profile07.phpt]
┃        > PASS SimpleXML [profile]: Accessing a namespaced attribute without a namespace [tests/profile08.phpt]
┃        > PASS SimpleXML [profile]: Accessing a namespaced element without a namespace [tests/profile09.phpt]
┃        > PASS SimpleXML [profile]: Accessing two attributes with the same name, but different namespaces [tests/profile10.phpt]
┃        > PASS SimpleXML [profile]: Accessing two elements with the same name, but different namespaces [tests/profile11.phpt]
┃        > PASS SimpleXML [profile]: Accessing namespaced root and non namespaced children [tests/profile12.phpt]
┃        > PASS SimpleXML [profile]: Accessing by namespace prefix [tests/profile13.phpt]
┃        > SKIP SimpleXML [interop]: simplexml_import_dom [tests/simplexml_import_dom.phpt] reason: Required extension missing: dom
┃        > PASS simplexml_load_file() [tests/simplexml_load_file.phpt]
┃        > PASS Incorrectly initialized SimpleXmlElement [tests/simplexml_uninitialized.phpt]
┃        > PASS SPL: SimpleXMLIterator [tests/sxe_001.phpt]
┃        > PASS SPL: SimpleXMLIterator and recursion [tests/sxe_002.phpt]
┃        > PASS SPL: SimpleXMLIterator and getChildren() [tests/sxe_003.phpt]
┃        > PASS SPL: SimpleXMLIterator and overridden iterator methods() [tests/sxe_004.phpt]
┃        > PASS SPL: SimpleXMLIterator and overridden count() [tests/sxe_005.phpt]
┃        > =====================================================================
┃        > TIME END 2024-07-30 16:46:43
┃        >
┃        > =====================================================================
┃        > TEST RESULT SUMMARY
┃        > ---------------------------------------------------------------------
┃        > Exts skipped    :    0
┃        > Exts tested     :   12
┃        > ---------------------------------------------------------------------
┃        >
┃        > Number of tests :  131               127
┃        > Tests skipped   :    4 (  3.1%) --------
┃        > Tests warned    :    0 (  0.0%) (  0.0%)
┃        > Tests failed    :    1 (  0.8%) (  0.8%)
┃        > Tests passed    :  126 ( 96.2%) ( 99.2%)
┃        > ---------------------------------------------------------------------
┃        > Time taken      :    1 seconds
┃        > =====================================================================
┃        >
┃        > =====================================================================
┃        > FAILED TEST SUMMARY
┃        > ---------------------------------------------------------------------
┃        > Bug #79971 (special character is breaking the path in xml function) [tests/bug79971_1.phpt]
┃        > =====================================================================
┃        > make: *** [Makefile:136: test] Error 1
┃        For full logs, run 'nix log /nix/store/qhz26ig0n0d43xapgjwp2rj1nllfi133-php-simplexml-8.1.29.drv'.

Additional context

This happen after latest flake update

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 6.10.1, NixOS, 24.11 (Vicuna), 24.11.20240727.b73c222`
 - multi-user?: `yes`
 - sandbox: `relaxed`
 - version: `nix-env (Nix) 2.18.5`
 - channels(root): `"home-manager-23.11.tar.gz, nixos-23.11"`
 - nixpkgs: `/nix/store/qxf6anli54ij0q1sdlnlgx9hyl658a4v-source`

Add a 👍 reaction to issues you find important.

@ghpzin
Copy link
Contributor

ghpzin commented Jul 30, 2024

Hydra build php81Extensions.simplexml:
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.php81Extensions.simplexml.x86_64-linux
https://hydra.nixos.org/build/267699505

php82Extensions.simplexml and php83Extensions.simplexml seem fine:
https://hydra.nixos.org/build/267607665
https://hydra.nixos.org/build/267656758

Probably related:
#330299 (fixes for 8.2 and 8.3 with same error)

8.1 is out of active support, so there was no backport for php/php-src#14789 from upstream

PS you did not ping any maintainers for that package, so they would need to notice this issue (which is unlikely)

@ClockGen
Copy link

Also causes an lsp-plugins build failure.
Gonna ping maintainers.

@aanderse
@drupol
@Ma27
@patka-123
@talyz

@jys1670
Copy link

jys1670 commented Jul 30, 2024

Also causes an lsp-plugins build failure.

this is fixed in master
#330895

@skylarmb
Copy link

forgive my ignorance, but what needs to happen for the fix on master to make its way to the unstable channel? I would love to be able to rebuild my system soon

@ghpzin
Copy link
Contributor

ghpzin commented Jul 30, 2024

#330895 fixed "lsp-plugins build failure" (it does not depend on php 8.1 version now)
If your system update depends on php81Extensions.simplexml in some other way it won't help.
php81Extensions.simplexml does not build on current master as of 6f7b496 (2024-07-30T19:50:23Z)

@Andy3153
Copy link
Member

forgive my ignorance, but what needs to happen for the fix on master to make its way to the unstable channel? I would love to be able to rebuild my system soon

Well if you only need to rebuild your system again and you don't necessarily care about the updates you're missing out on, you can try using a previous version of your flake.lock file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants