Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libjpeg_turbo: 2.1.5.1 -> 3.0.2 #285136

Merged
merged 1 commit into from
Feb 1, 2024
Merged

libjpeg_turbo: 2.1.5.1 -> 3.0.2 #285136

merged 1 commit into from
Feb 1, 2024

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jan 31, 2024 •
edited
Loading

Description of changes

Closes #248969.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais alyssais requested a review from L-as January 31, 2024 00:37
@alyssais alyssais mentioned this pull request Jan 31, 2024
Merged
12 tasks
@vcunat
Copy link
Member

vcunat commented Jan 31, 2024

This overlaps with PR #248969 but that's not really an issue.

@vcunat
Copy link
Member

vcunat commented Jan 31, 2024 •
edited
Loading

Generally I assume it will be OK to try 3.0.x at this point.

@alyssais
Copy link
Member Author

I've confirmed that graphicsmagick (mentioned as a problem in the other PR) is fine now.

L-as
L-as approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@L-as L-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alyssais alyssais merged commit 8318842 into NixOS:staging Feb 1, 2024
30 checks passed
@alyssais alyssais deleted the libjpeg_turbo-3.0.2 branch February 1, 2024 20:16
@alyssais alyssais mentioned this pull request Feb 1, 2024
Closed
12 tasks
@wegank wegank mentioned this pull request Feb 1, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-as L-as L-as approved these changes

@colemickens colemickens Awaiting requested review from colemickens

@kamadorueda kamadorueda Awaiting requested review from kamadorueda

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alyssais @vcunat @L-as @delroth