Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libjpeg_turbo: 2.1.5.1 -> 3.0.0 #248969

Closed
wants to merge 2 commits into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Aug 13, 2023

Description of changes

I would mark this with a Security label due to https://nvd.nist.gov/vuln/detail/CVE-2023-2804, but I'm fairly certain that doesn't apply to us, because it's specifically in the 12-bit code and we don't build with 12-bit enabled.

Also successfully built pkgsStatic, pkgsMusl & pkgsCross.aarch64-multiplatform variants.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Aug 13, 2023

There are API-breaking changes, so I don't expect it will be smooth so soon after releasing upstream.

@risicle
Copy link
Contributor Author

risicle commented Aug 13, 2023

Possibly. However, it looks like the API changes are in the turbojpeg API, and I suspect the vast vast majority of packages will be using the libjpeg API.

@risicle risicle changed the title libjpeg-turbo: 2.1.5.1 -> 3.0.0 libjpeg_turbo: 2.1.5.1 -> 3.0.0 Aug 13, 2023
@risicle
Copy link
Contributor Author

risicle commented Aug 13, 2023

Looks like you're right and we have our first candidate.

@ofborg build graphicsmagick

@risicle
Copy link
Contributor Author

risicle commented Aug 13, 2023

This seems to solve it

@ofborg build graphicsmagick

@risicle risicle marked this pull request as ready for review August 14, 2023 00:43
@risicle risicle changed the base branch from master to staging August 14, 2023 00:46
@vcunat vcunat mentioned this pull request Jan 31, 2024
13 tasks
@alyssais
Copy link
Member

alyssais commented Feb 1, 2024

Done in #285136.

@alyssais alyssais closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants