-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cudaPackages: replace the FHS paths in pkg-config files #275921
Conversation
3fbafef
to
684ca4d
Compare
(squashed the fixup) Thanks @aidalgol! I think we still need to run the builds to see that e.g. the FHS scan didn't break any more packages |
684ca4d
to
cfa0701
Compare
Result of 41 packages marked as broken and skipped:
37 packages failed to build:
71 packages built:
Logs: https://gist.github.com/SomeoneSerge/cf6f131abb2f71f55996dc86104edbc6 Most of these fail with "Detected references to /usr" so I'm going to make |
...harden gradually instead
Result of 41 packages marked as broken and skipped:
8 packages failed to build:
100 packages built:
Logs: https://gist.github.com/SomeoneSerge/58537247af3cabcffb57465005497f65
Neither are related to this PR |
if [[ -d pkg-config ]] ; then | ||
mkdir -p share/pkg-config | ||
mv pkg-config/* share/pkg-config/ | ||
rmdir pkg-config | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs/pkgs/build-support/pkg-config-wrapper/setup-hook.sh
Lines 15 to 18 in 9be1431
addToSearchPath "PKG_CONFIG_PATH${role_post}" "$1/lib/pkgconfig" | |
addToSearchPath "PKG_CONFIG_PATH${role_post}" "$1/share/pkgconfig" | |
} |
🤦🏻 🤦🏻 🤦🏻
Cf. #224119
@NixOS/cuda-maintainers
Description of changes
libdir = /usr/local/whatever
withlibdir = ${!outputLib}
, etcThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.