cudaPackages: bump the default 11 -> 12 #269639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeoneSerge
changed the title
ofborg
bot
added
8.has: clean-up
8.has: package (new)
|
Result of 95 packages marked as broken and skipped:
1266 packages failed to build:
96 packages built:
|
|
Eh, I ran out of disk |
|
Result of 22 packages marked as broken and skipped:
29 packages failed to build:
86 packages built:
|
|
TF seems to have introduced CUDA 12 support in version 2.15.0, so if we upgrade TF we can likely get rid of Completing a TF upgrade should not be a blocker for this PR IMHO, but just wanted to note that for future work. |
I feel like TF has been generally lagging behind and offering a narrower compatibility window, compared to anything else including pytorch. That's the reason we had the overrides inheriting tensorflow-bin's cudaPackages for tensorflow and jax, isn't it? I don't expect this to change. I anticipate that with the next cuda release we'd have to reintroduce the pins |
aidalgol
reviewed
Nov 25, 2023
Ok so I did it super-dirty just to get the eval fixed and nixpkgs-review running, but basically what happens here is that unless It's ugly, it's wrong, it's an overkill, and we have better prospects with the refactoring being worked on in #256324. And we haven't settled on the convention of either leaving out the unsupported attributes, or marking them "broken": #266475. |
aidalgol
approved these changes
Nov 25, 2023
delroth
added
12.approvals: 1
|
@aidalgol could you confirm I didn't break the existing trt packages? Or maybe I ask you again after the nixpkgs-review, because I'll probably have to push more fix-ups |
|
This is how I tested TensorRT when first adding it to $ NIX_PATH=nixpkgs=$PWD NIXPKGS_ALLOW_UNFREE=1 nix-shell -p 'python310.withPackages (pypkgs: [ pypkgs.tensorrt ])'
$ python3 -c 'import tensorrt; assert tensorrt.Builder(tensorrt.Logger())'I think it would be the same, only with |
|
EDIT: lol it should've been Result of 121 packages marked as broken and skipped:
405 packages failed to build:
1408 packages built:
|
|
Catboost fails because of the unsupported architectures too. I tried overriding the cuda architectures for catboost but failed, they're hard-coded in more than one place. I guess we'll have to force it to use Tracking override-ability in catboost/catboost#2540 |
|
Also I can't publish the logs because Mic92/nixpkgs-review#379 |
This comment was marked as outdated.
This comment was marked as outdated.
SomeoneSerge
force-pushed
the
update/cudaPackages
branch
from
92117ec to
c32e620
Compare
|
The
Somebody's got to untangle this mess, but not in this PR I think |
SomeoneSerge
added a commit
to SomeoneSerge/nixpkgs-cuda-ci
that referenced
this pull request
Dec 11, 2023
SomeoneSerge
force-pushed
the
update/cudaPackages
branch
from
12ddc09 to
af3b878
Compare
SomeoneSerge
added a commit
to SomeoneSerge/nixpkgs-cuda-ci
that referenced
this pull request
Dec 11, 2023
SomeoneSerge
added a commit
to SomeoneSerge/nixpkgs-cuda-ci
that referenced
this pull request
Dec 12, 2023
SomeoneSerge
added a commit
to SomeoneSerge/nixpkgs-cuda-ci
that referenced
this pull request
Dec 12, 2023
SomeoneSerge
added a commit
to SomeoneSerge/nixpkgs-cuda-ci
that referenced
this pull request
Dec 20, 2023
SomeoneSerge
force-pushed
the
update/cudaPackages
branch
from
b834b62 to
ad5b156
Compare
SomeoneSerge
added a commit
to SomeoneSerge/nixpkgs-cuda-ci
that referenced
this pull request
Dec 20, 2023
|
#275709 is somewhat of a blocker, although I'm willing to just break them |
|
#275939 is a blocker because we can't get anything reasonable from Ofborg |
This was referenced Dec 25, 2023
SomeoneSerge
force-pushed
the
update/cudaPackages
branch
from
ad5b156 to
640bd65
Compare
SomeoneSerge
force-pushed
the
update/cudaPackages
branch
from
640bd65 to
8ddc8e3
Compare
github-actions
bot
added
6.topic: nixos
|
@ConnorBaker I want to merge this as soon as ofborg allows. The nsight_systems fix is super ugly and I'm content with that. |
samuela
reviewed
Jan 17, 2024
ConnorBaker
approved these changes
Jan 17, 2024
|
Added a commit to address @samuela's notes so the checks are gone, but ofborg has passed previously: https://github.com/NixOS/nixpkgs/pull/269639/checks?check_run_id=20566378248 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
WIP. Addresses #222778
Things done
nixpkgs-review --extra-nixpkgs-config '{ cudaSupport = true; }'@NixOS/cuda-maintainers
Priorities
Add a 👍 reaction to pull requests you find important.